Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 323385 - Java discovery settings "filter" radio buttons
Summary: Java discovery settings "filter" radio buttons
Status: CLOSED FIXED
Alias: None
Product: MoDisco
Classification: Modeling
Component: Infrastructure (show other bugs)
Version: 0.9.0   Edit
Hardware: All All
: P1 trivial (vote)
Target Milestone: 0.9.0 M3   Edit
Assignee: Fabien Giquel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-23 09:02 EDT by Nicolas Bros CLA
Modified: 2010-10-21 05:11 EDT (History)
5 users (show)

See Also:
fabien.giquel: indigo+

Attachments
Improve Java discover settings "filter" radio buttons (8.09 KB, patch)
2010-09-20 05:58 EDT, Romain Dervaux CLA 		fabien.giquel: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Bros CLA 2010-08-23 09:02:43 EDT 
When it first opens, the Java discovery settings dialog has neither "Do not analyze types/packages..." and "Analyze only types/packages..." selected (in the "Filter" group).
If you click on either of those radio buttons, you can never return to the initial state -- that is both radio buttons deselected.

I believe there should be a third radio button which represents the default, and which is selected initially. For example: "Analyze all types/packages".
Comment 1 Romain Dervaux CLA 2010-09-20 05:58:28 EDT 
Created attachment 179232 [details]
Improve Java discover settings "filter" radio buttons
Comment 2 Romain Dervaux CLA 2010-09-20 05:59:04 EDT 
Hi.

Here is a patch which provides the requested feature.
It allowed me to detect and correct a bug : 

If the user entered a regexp in the excluded elements, then click on the included elements radio button to finally close the wizard, the discoverer will in all cases eliminate the elements designated in the excluded elements. 
Same problem with included elements.

That's because the DiscoveryParametersBean object in the org.eclipse.gmt.modisco.java.actions.ui.JavaWizardFirstPage class is updated in the validatePage() method, which is not called when the user close the wizard ("Finish" button) or when the user choose the "(Do not) Analyse only types/packages..." radio buttons.

Hope it's clear.
Comment 3 Fabien Giquel CLA 2010-10-04 13:28:08 EDT 
Well done,
thank you for your path. It has been commited into SVN.

Fabien.
Comment 4 Fabien Giquel CLA 2010-10-04 13:32:23 EDT 
Too fast. I forgot to ask you the usual confirmations :

(a)  I wrote 100% of the code I’ve provided 
(b)  I have the right to contribute the code to Eclipse
(c)  I contribute the content under the EPL.

Thanks.

The contribution is less than 250 lines and does not require CQ.
Comment 5 Romain Dervaux CLA 2010-10-05 07:34:27 EDT 
1. I, DERVAUX romain, and others contributors listed in this bug, authored 100%
of the content
2. I have the rights to donate the content to Eclipse under the EPL
3. I have already provided the filled Employer Consent Forms to the Foundation

Romain DERVAUX
Comment 6 Fabien Giquel CLA 2010-10-05 08:00:53 EDT 
Mark the bug as fixed.
Comment 7 Hugo Bruneliere CLA 2010-10-21 05:11:01 EDT 
The patch has been successfully integrated.