Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 323375 - [backport] fix for bug 296576 in 3.0 and 3.1 branches for WTP
Summary: [backport] fix for bug 296576 in 3.0 and 3.1 branches for WTP
Status: RESOLVED FIXED
Alias: None
Product: WTP ServerTools
Classification: WebTools
Component: jst.server (show other bugs)
Version: 3.0.5   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.0.5 P   Edit
Assignee: Angel Vera CLA
QA Contact: Angel Vera CLA
URL:
Whiteboard:
Keywords:
: 324550 330478 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-08-23 06:14 EDT by Krzysztof Kazmierczyk CLA
Modified: 2010-11-24 10:56 EST (History)
1 user (show)

See Also:


Attachments
patch for 3.0-maintenance (5.33 KB, patch)
2010-08-23 06:52 EDT, Krzysztof Kazmierczyk CLA
no flags Details | Diff
Simpler patch (1.16 KB, patch)
2010-09-06 04:05 EDT, Krzysztof Daniel CLA
no flags Details | Diff
v1.1 (1.57 KB, patch)
2010-10-13 16:18 EDT, Angel Vera CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Kazmierczyk CLA 2010-08-23 06:14:02 EDT
Build Identifier: 

We need fix for bug 296576 (RuntimeClasspathProviderWrapper methods can be called by multiple threads but aren't thread safe) in branches 3.0-maintenance and 3.1-maintenance.
The fix is necessary for Eclipse based product to increase user satisfaction.

Reproducible: Always
Comment 1 Krzysztof Kazmierczyk CLA 2010-08-23 06:16:42 EDT
Patch for 3.1 is the same as to 3.2 branch and available under https://bugs.eclipse.org/bugs/attachment.cgi?id=157464
Comment 2 Krzysztof Kazmierczyk CLA 2010-08-23 06:52:47 EDT
Created attachment 177202 [details]
patch for 3.0-maintenance

The patch for 3.0.
We needed to add import of java.util.Collections and manually modify changes for resolveClasspathContainerImpl method.
Comment 3 Angel Vera CLA 2010-09-02 10:37:25 EDT
Kryztof, why was the RutnimeClasspathProviderWrapper part not included into your 3.0 patch?
Comment 4 Krzysztof Daniel CLA 2010-09-06 04:03:50 EDT
*** Bug 324550 has been marked as a duplicate of this bug. ***
Comment 5 Krzysztof Daniel CLA 2010-09-06 04:05:39 EDT
Created attachment 178241 [details]
Simpler patch

This is much simpler patch which also seems to resolve the issue.
Comment 6 Angel Vera CLA 2010-10-13 16:18:21 EDT
Created attachment 180824 [details]
v1.1

Added updated copyrights from the patch# 178241
Comment 7 Angel Vera CLA 2010-11-02 15:11:41 EDT
It looks like this fix was already included in the patches build, but it was
never marked as fixed. I checked the R3_0_5_patches version of RuntimeClasspathProviderDelegate and it
does indeed look like the changes were committed. I am now marking this as
fixed.
Comment 8 Angel Vera CLA 2010-11-24 10:56:05 EST
*** Bug 330478 has been marked as a duplicate of this bug. ***