Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 323285 - Preference initializers are loading template stores adding to editor loading time
Summary: Preference initializers are loading template stores adding to editor loading ...
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.sse (show other bugs)
Version: 3.2.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.2   Edit
Assignee: Nick Sandonato CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-20 14:53 EDT by Nick Sandonato CLA
Modified: 2010-08-23 10:21 EDT (History)
0 users

See Also:
thatnitind: review+

Attachments
patch (22.60 KB, patch)
2010-08-20 15:28 EDT, Nick Sandonato CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Sandonato CLA 2010-08-20 14:53:17 EDT 
+++ This bug was initially created as a clone of Bug #323284 for porting to 3.2.x +++

Created an attachment (id=177132)
patch

It looks like the preference initializers are loading template stores in order to set up a default value for the default template name. I've seen this fix shave off anywhere from 200ms to 2s, seemingly dependent on other disk IO.
Comment 1 Nick Sandonato CLA 2010-08-20 15:28:40 EDT 
Created attachment 177137 [details]
patch

Patch to remove template store loading from preference initialization.
Comment 2 Nitin Dahyabhai CLA 2010-08-21 12:47:39 EDT 
Approved, particularly since other plug-ins are free to contribute to our template contexts.
Comment 3 Nick Sandonato CLA 2010-08-23 10:21:49 EDT 
Code released. Thanks, Nitin.