Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 323239 - Git configuration editor should have "Apply" and "Cancel"
Summary: Git configuration editor should have "Apply" and "Cancel"
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 0.9.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 0.9.0-M3   Edit
Assignee: Mathias Kinzler CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-20 08:04 EDT by Mathias Kinzler CLA
Modified: 2010-08-23 14:31 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mathias Kinzler CLA 2010-08-20 08:04:29 EDT
Currently, the changes in the editor are always committed to the configuration immediately. Instead, there should be some "Apply" (or "Save") button and the changes should be done in memory only until the user hits this button.
Comment 1 Mathias Kinzler CLA 2010-08-23 13:57:26 EDT
Code review at http://egit.eclipse.org/r/#change,1379
Comment 2 Chris Aniszczyk CLA 2010-08-23 14:31:15 EDT
Fixed with 0ab338b06801b1c5dab4943a2329461115c5c0f6.

Thanks Mathias.