Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 323201 - Cannot use double-click to expand/collapse tree nodes in the 'Synchronize' view
Summary: Cannot use double-click to expand/collapse tree nodes in the 'Synchronize' view
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 0.9.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.9.0-M2   Edit
Assignee: Dariusz Luksza CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 323275 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-08-19 20:24 EDT by Remy Suen CLA
Modified: 2010-08-22 07:34 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-08-19 20:24:22 EDT 
This bug is driving me crazy.
Comment 1 Remy Suen CLA 2010-08-19 20:57:29 EDT 
To fix this bug, please implement equals(Object) and hashCode() correctly in GitModelCommit and its subclasses.

hashCode() only considers 'remoteCommit' at the moment which is most certainly off.

equals(Object) is also incorrect as it does something similar by comparing a RevCommit with the target object. We should be comparing GitModelCommits with another GitModelCommit.
Comment 2 Dariusz Luksza CLA 2010-08-20 14:00:53 EDT 
Here is fix for this issue:

http://egit.eclipse.org/r/1357
Comment 3 Chris Aniszczyk CLA 2010-08-20 18:52:57 EDT 
Fixed with 7d7525e8413a314f2a0dfa1d00ffb4f75ab6dd9a.
Comment 4 Remy Suen CLA 2010-08-22 07:34:12 EDT 
*** Bug 323275 has been marked as a duplicate of this bug. ***