Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 323197 - NPE in pdebuild if a dropins/somefile.link has a path that doesn't exist
Summary: NPE in pdebuild if a dropins/somefile.link has a path that doesn't exist
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Build (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6.1   Edit
Assignee: pde-build-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-19 19:17 EDT by John Cortell CLA
Modified: 2010-08-20 12:30 EDT (History)
2 users (show)

See Also:

Attachments
NPE stack crawl (3.63 KB, text/plain)
2010-08-19 19:18 EDT, John Cortell CLA 		no flags Details
patch (983 bytes, patch)
2010-08-20 12:17 EDT, Andrew Niefer CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Cortell CLA 2010-08-19 19:17:57 EDT 
See attached exception callstack.

PluginPathFinder.getDropins() doesn't consider that getSitePath() might return null, and blindly creates a java.io.File object with the result.

Note that getSites() does protect itself from the same thing.
Comment 1 John Cortell CLA 2010-08-19 19:18:15 EDT 
Created attachment 177056 [details]
NPE stack crawl
Comment 2 Andrew Niefer CLA 2010-08-20 12:17:39 EDT 
Created attachment 177109 [details]
patch
Comment 3 Darin Wright CLA 2010-08-20 12:24:29 EDT 
+1 for 3.6.1
Comment 4 Andrew Niefer CLA 2010-08-20 12:30:44 EDT 
Done in HEAD and 361.  Too bad all the bugs aren't this easy :)