Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 323173 - ToggleBreakpointAdapter should never create a breakpoint on the workspace root
Summary: ToggleBreakpointAdapter should never create a breakpoint on the workspace root
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: Debug (show other bugs)
Version: 3.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.3 M2   Edit
Assignee: Michael Rennie CLA
QA Contact: Simon Kaegi CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-19 12:23 EDT by Michael Rennie CLA
Modified: 2010-08-19 12:24 EDT (History)
1 user (show)

See Also:

Attachments
fix (4.99 KB, patch)
2010-08-19 12:23 EDT, Michael Rennie CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2010-08-19 12:23:11 EDT 
Created attachment 177022 [details]
fix

code from HEAD

we have some bogus logic in our ToggleBreakpointAdapter that will return the workspace root as a resource for a line or function breakpoint if the JavaScriptModel fails to return the backing resource. This is bogus because the breakpoint cannot be removed easily, and it won't appear in the editor you tried to put it in.

The patch removes this logic and correctly reports to the status line why the breakpoint could not be created.
Comment 1 Michael Rennie CLA 2010-08-19 12:24:05 EDT 
applied to HEAD