Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 323121 - Make shared window images UI session scoped
Summary: Make shared window images UI session scoped
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: Workbench (show other bugs)
Version: 1.3   Edit
Hardware: PC All
: P3 enhancement (vote)
Target Milestone: 3.0 M1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 425861 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-08-19 06:35 EDT by Yury CLA
Modified: 2014-07-24 08:16 EDT (History)
3 users (show)

See Also:

Attachments
proposed patch (4.08 KB, patch)
2010-08-19 06:36 EDT, Yury CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury CLA 2010-08-19 06:35:11 EDT 
Build Identifier: RAP 1.3

Now Window.defaultImages is a static filed and images is shared between users. The case than a user close the workbench and another user start another session we can get the following situation:
2nd user start new session and initialize images by Workbench.initializeImages();
1st user close Workbench and set null defaultImages in Workbench.uninitializeImages();
2nd user open the workbench window and configure the shell in Window.configureShell(Shell newShell) and get there null images array!

I suppose to put the Window.defaultImages in session scope as it is done for WorkbenchImages (example patch is attached).

Reproducible: Sometimes
Comment 1 Yury CLA 2010-08-19 06:36:55 EDT 
Created attachment 176977 [details]
proposed patch
Comment 2 Ivan Furnadjiev CLA 2010-08-19 07:32:53 EDT 
Hi Yury, thanks for the patch. We will look on it as soon as possible.
Comment 3 Ivan Furnadjiev CLA 2014-07-21 06:45:53 EDT 
*** Bug 425861 has been marked as a duplicate of this bug. ***
Comment 4 Ivan Furnadjiev CLA 2014-07-24 08:16:48 EDT 
Fixed with change https://git.eclipse.org/r/30177.