Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 323082 - Manifest entries not showing correct paths if the module's deploy path was modified
Summary: Manifest entries not showing correct paths if the module's deploy path was mo...
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.2   Edit
Assignee: Aidyl Kareh CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-18 15:43 EDT by Aidyl Kareh CLA
Modified: 2010-08-25 13:11 EDT (History)
3 users (show)

See Also:
cbridgha: review+
jsholl: review+

Attachments
Proposed Patch (12.34 KB, patch)
2010-08-18 15:52 EDT, Aidyl Kareh CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aidyl Kareh CLA 2010-08-18 15:43:40 EDT 
Build Identifier: WTP 3.2.2

When adding manifest entries to modules using the 'Deployment Assembly' page, the deploy path of the module is currently not being considered when generating the path for the manifest entry.

Steps to recreate:
1) Create an EAR 6 project with all default modules.
2) Open the EAR's Deployment Assembly page and change the deploy path of the Web project (i.e. /test/TestWeb.war)
3) Open the Web project's 'Deployment Assembly' properties page, go to the 'Manifest Entries' tab and add a manifest entry to the EJB project.
4) Open the Web project's MANIFEST.MF file. You will see that the entry only shows the name of the .jar file without taking into consideration the path of the Web module (This entry should be '../TestEJB.jar')

Reproducible: Always
Comment 1 Aidyl Kareh CLA 2010-08-18 15:52:31 EDT 
Created attachment 176937 [details]
Proposed Patch

The attached patch updates the JEEManifestDiscerner class so that instead of just using the reference's deploy path when creating the a manifest entry, now the deploy path of the project that owns the MANIFEST.MF file is also taken into consideration. The ClassPathSelection class was also updated to handle this scenario.
Comment 2 Chuck Bridgham CLA 2010-08-23 13:16:14 EDT 
approved
Comment 3 Jason Sholl CLA 2010-08-24 16:19:17 EDT 
checked into head for wtp 3.2.2
Comment 4 Jason Sholl CLA 2010-08-25 13:11:09 EDT 
fixed