Community
Participate
Working Groups
Created attachment 176930 [details] New Indexer Patch We need a way to wait for the JSP index to be consistent before performing operations like searches. Long story short, the best way to go about doing this was to re-in-vision the JSP indexer. I took it a step further and wrote a generic Index manager that could manage tracking any type of file in the workspace and then wrote an implementation of it designed to track JSP pages. This JSP tracker takes care of injecting JSPs into the JDT index and also calling the API to persist the translations. The framework for this generic index manager was very much based of how the JSPTranslatorPersister worked. Part of my changes were to rip out all the code the JSPTranslatorPersister used to track JSP changes and to just have the new JSPIndexManager use the JSPTranslatorPersister to persist the translations for the JSP files it finds. I have only done some basic testing on this new indexer including running all the Junits. Still needs much testing but its about time someone else take a gander at the code. Patch attached.
Note that this bug does not fix the issues caused by Bug 308402
Created attachment 177308 [details] New Indexer Patch - Update 1 Same as previous patch only now with better status reporting when a Java search is waiting on the JSP Index Manager to finish its work.
Created attachment 177736 [details] New Indexer Patch - Update 2 Did some patch clean up to get rid of some unnecessary changes that Nick found in his review. Also updated to incorporate the fixes put in for Bug 317830.
Also related to this is Bug 323973
Created attachment 177739 [details] New Indexer Patch - Update 3 The last patch accidentally included the fix for Bug 323973
Created attachment 178037 [details] New Indexer Patch - Update 4 Updated patch to react to JDTs findings in Bug 323392. Had to remove an old "hack" line we had in there to try and get around Bug 308402. Everything seems to work great now (assuming you have some sort of fix for Bug 323973 applied as well and have the latest JDT code that includes the fix for Bug 308402)
Created attachment 182328 [details] New Indexer Patch - Update 5 Updated patch with Nitin and Nick's offline comments. Also updated patch to not use any new strings. Not as verbose, but still better then what we have.
Created attachment 182725 [details] New Indexer Patch - Update 6 Fix conflict in patch due to recent changes in sse.core. Fixed an NPE that was only showing up when the JSPCore tests were run on their own and not as part of the entire SSE test suite, thanks to Nick for the catch.
I think the patch looks pretty good now.
Released to 3.2.3.
