Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 322975 - FeatureData writes attributes without encoding
Summary: FeatureData writes attributes without encoding
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.7 M4   Edit
Assignee: Martin Karpisek CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2010-08-18 02:04 EDT by Thomas Hallgren CLA
Modified: 2016-12-06 15:28 EST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Hallgren CLA 2010-08-18 02:04:38 EDT 
The recent introduction of filters in feature's includes/requires (see bug 293715) leads to problems when a feature is serialized. The class org.eclipse.pde.internal.core.feature.FeatureData simply writes the filter attribute as a string without encoding the '&' character into the XML entity &.

The writeAttribute method of that class needs some escape mechanism when writing the actual value (FeatureData.java line 80).
Comment 1 Curtis Windatt CLA 2010-08-18 09:28:44 EDT 
Needs investigation
Comment 2 Thomas Hallgren CLA 2010-10-15 02:11:34 EDT 
Any progress with the investigation?

We create features that import platform specific fragments. The feature itself isn't platform specific and contains fragments for all platforms. Without the filters, we get lots of build time warnings about 'Plug-in reference x.y.z cannot be resolved' for all references that doesn't match the current platform. That's because the plug-in itself has a filter.
Comment 3 Curtis Windatt CLA 2010-10-18 15:05:31 EDT 
This is not a priority item and has not been looked at.  Assistance from the community would be appreciated.
Comment 4 Eclipse Genie CLA 2016-10-15 09:28:56 EDT 
New Gerrit change created: https://git.eclipse.org/r/83297
Comment 6 Lars Vogel CLA 2016-11-28 15:02:56 EST 
Thanks Martin.
Comment 7 Vikas Chandra CLA 2016-12-05 04:23:05 EST 
Martin, can you please verify this fix in latest 4.7?
Comment 8 Martin Karpisek CLA 2016-12-06 15:28:02 EST 
verified by doing serialization of feature data

Version: Oxygen (4.7)
Build id: I20161205-2000