Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 322954 - [model] Improper reconciliation of soap:body parts when used in a MIME binding context
Summary: [model] Improper reconciliation of soap:body parts when used in a MIME bindin...
Status: CLOSED FIXED
Alias: None
Product: WTP Webservices
Classification: WebTools
Component: wst.wsdl (show other bugs)
Version: 3.0.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.0.5 P   Edit
Assignee: Valentin Baciu CLA
QA Contact: Keith Chong CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 322955 322956
  Show dependency tree
 
Reported: 2010-08-17 16:54 EDT by Valentin Baciu CLA
Modified: 2010-08-25 11:49 EDT (History)
1 user (show)

See Also:
keith.chong.ca: review+

Attachments
JUnit (6.41 KB, patch)
2010-08-17 19:03 EDT, Valentin Baciu CLA 		no flags Details | Diff
Patch (4.14 KB, patch)
2010-08-17 19:04 EDT, Valentin Baciu CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Valentin Baciu CLA 2010-08-17 16:54:48 EDT 
The WSDL EMF model's DOM to model reconciliation code for a SOAP body object assumes that the SOAP body extensibility element is a direct child of a binding's input/output/fault. This is not always the case, in particular when a SOAP body is used inside a MIME binding.

      <wsdl:input name="myOpRequest">
        <mime:multipartRelated>
          <mime:part>
            <soap:body parts="in1" use="literal"/>
          </mime:part>

Because of this assumption, the value of the parts attribute is not saved in the model and thus will be lost when forcing the model to reconcile the DOM using updateElement(true).

JUnit and fix to follow shortly.
Comment 1 Valentin Baciu CLA 2010-08-17 19:03:12 EDT 
Created attachment 176851 [details]
JUnit

Apply to org.eclipse.wst.wsdl.tests. Run org.eclipse.wst.wsdl.tests.AllTestCases as a JUnit plug-in test. The new test case will fail.
Comment 2 Valentin Baciu CLA 2010-08-17 19:04:05 EDT 
Created attachment 176852 [details]
Patch

Apply to org.eclipse.wst.wsdl, R3_0_5_patches branch.
Rerun the JUnits, all should be green.
Comment 3 Valentin Baciu CLA 2010-08-18 10:35:11 EDT 
Keith, please review and consider approving this fix for 3.0.5 patches.
Comment 4 Keith Chong CLA 2010-08-19 11:16:54 EDT 
Valentin, patch and junit tests look good.
Comment 5 Carl Anderson CLA 2010-08-20 08:07:02 EDT 
Committed to R3_0_5_patches
Comment 6 Valentin Baciu CLA 2010-08-25 11:49:38 EDT 
Verified. Closing.