Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 322935 - NPE in RevCommit.getAuthorIdent()
Summary: NPE in RevCommit.getAuthorIdent()
Status: RESOLVED INVALID
Alias: None
Product: JGit
Classification: Technology
Component: JGit (show other bugs)
Version: 0.9.0   Edit
Hardware: PC Linux
: P3 minor (vote)
Target Milestone: 0.9.0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 323123 (view as bug list)
Depends on:
Blocks: 322732
  Show dependency tree
 
Reported: 2010-08-17 13:08 EDT by Dariusz Luksza CLA
Modified: 2010-08-19 10:23 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dariusz Luksza CLA 2010-08-17 13:08:52 EDT
Build Identifier: 

It looks like JGit for some strange reasons lost reference to author indent.

As far as I investigate it, this occurs only in EGit Synchronization and *only* for latest commit that is displayed in Sync-view.

Initially for obtaining base commit in GitModelCommit class I use remote commit parent using this call:
remoteCommit.getParent(0);
But during debugging it occurs that sometimes:
remoteCommit.getParent(0).getAuthorIdent();
throws NPE even when theirs ObjectId were returned properly. Therefore I've used RevWalk to re-parse RevCommit object. This seams to work because none of baseCommit.getAuthorIdent() throws NPE.

But suddenly it occur that re-parsed object few moments after it is re-parsed also loses reference to author indent

Reproducible: Always
Comment 1 Chris Aniszczyk CLA 2010-08-19 10:03:39 EDT
*** Bug 323123 has been marked as a duplicate of this bug. ***
Comment 2 Chris Aniszczyk CLA 2010-08-19 10:04:24 EDT
Upping the severity as people are hitting this in the field more often now when playing with the nightlies.
Comment 3 Dariusz Luksza CLA 2010-08-19 10:23:32 EDT
According to Shawn's mail on jgit-dev[1], this isn't a bug but consequence of keeping high performance on JGit implementation. I'll fix this in EGit in a few moments ;)

1. http://dev.eclipse.org/mhonarc/lists/jgit-dev/msg00566.html