Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 322910 - Display name adornments should always be computed in JavaScriptModelPresentation
Summary: Display name adornments should always be computed in JavaScriptModelPresentation
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: Debug (show other bugs)
Version: 3.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.3 M2   Edit
Assignee: Michael Rennie CLA
QA Contact: Simon Kaegi CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-17 11:21 EDT by Michael Rennie CLA
Modified: 2010-08-17 11:22 EDT (History)
1 user (show)

See Also:

Attachments
fix (22.70 KB, patch)
2010-08-17 11:21 EDT, Michael Rennie CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2010-08-17 11:21:18 EDT 
Created attachment 176798 [details]
fix

code from HEAD

Adornments for display names for our debug elements (thread, stackframe, etc) are computed all over the place, and should all be computed in the model presentation - that way they are not computed if the element is not going to be shown.

Also the name computation for a debug target should not happen in its constructor, as this requires a request of the VM would could fail, causing the constructor to blow up.
Comment 1 Michael Rennie CLA 2010-08-17 11:22:17 EDT 
applied to HEAD