Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 322868 - ArrayIndexOutOfBoundsException when using history view
Summary: ArrayIndexOutOfBoundsException when using history view
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 0.9.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.9.0-M3   Edit
Assignee: Stefan Lay CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-17 01:38 EDT by Marc-André Laperle CLA
Modified: 2010-08-25 00:32 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc-André Laperle CLA 2010-08-17 01:38:51 EDT 
EGit 0.9.0.201008162118
JGit 0.9.0.201008161610

This is when the History view is opened with either the "Show in History" in the menu of with the "Link with editor" enabled. When I click on the last entry in the list (or the only one) I get the exception.

java.lang.ArrayIndexOutOfBoundsException: 1
at org.eclipse.jgit.treewalk.TreeWalk.getObjectId(TreeWalk.java:664)
at org.eclipse.jgit.diff.DiffEntry.scan(DiffEntry.java:110)
at org.eclipse.egit.ui.internal.history.FileDiff.compute(FileDiff.java:57)
at org.eclipse.egit.ui.internal.history.FileDiffContentProvider.getElements(FileDiffContentProvider.java:38)
at org.eclipse.jface.viewers.StructuredViewer.getRawChildren(StructuredViewer.java:989)
at org.eclipse.jface.viewers.ColumnViewer.getRawChildren(ColumnViewer.java:703)
at org.eclipse.jface.viewers.AbstractTableViewer.getRawChildren(AbstractTableViewer.java:1087)
at org.eclipse.jface.viewers.StructuredViewer.getFilteredChildren(StructuredViewer.java:896)
at org.eclipse.jface.viewers.StructuredViewer.getSortedChildren(StructuredViewer.java:1046)
at org.eclipse.jface.viewers.AbstractTableViewer.internalRefreshAll(AbstractTableViewer.java:701)
at org.eclipse.jface.viewers.AbstractTableViewer.internalRefresh(AbstractTableViewer.java:649)
at org.eclipse.jface.viewers.AbstractTableViewer.internalRefresh(AbstractTableViewer.java:636)
at org.eclipse.jface.viewers.AbstractTableViewer$2.run(AbstractTableViewer.java:592)
at org.eclipse.jface.viewers.StructuredViewer.preservingSelection(StructuredViewer.java:1422)
at org.eclipse.jface.viewers.StructuredViewer.preservingSelection(StructuredViewer.java:1383)
at org.eclipse.jface.viewers.AbstractTableViewer.inputChanged(AbstractTableViewer.java:590)
at org.eclipse.jface.viewers.ContentViewer.setInput(ContentViewer.java:274)
at org.eclipse.jface.viewers.StructuredViewer.setInput(StructuredViewer.java:1664)
at org.eclipse.egit.ui.internal.history.GitHistoryPage$8.selectionChanged(GitHistoryPage.java:624)
Comment 1 Chris Aniszczyk CLA 2010-08-18 20:51:10 EDT 
This should be fixed with 44dfabcd07402170fe72242354cc40da71e557f4.
Comment 2 Mathias Kinzler CLA 2010-08-19 03:21:42 EDT 
This was a misunderstanding. 44dfabcd07402170fe72242354cc40da71e557f4 does not fix this issue, the corresponding change http://egit.eclipse.org/r/#change,1326 just mentions this as the root cause for some failing tests.
Comment 3 Stefan Lay CLA 2010-08-23 07:54:43 EDT 
Fix proposed for JGit: http://egit.eclipse.org/r/#change,1371
Comment 4 Chris Aniszczyk CLA 2010-08-24 10:36:21 EDT 
Should now be fixed with c2847d59f747ff94a90a6e37179b4e3ff042de55.
Comment 5 Marc-André Laperle CLA 2010-08-25 00:32:14 EDT 
(In reply to comment #4)
> Should now be fixed with c2847d59f747ff94a90a6e37179b4e3ff042de55.

I tested with 201008240008 (hudson #459) and I can't reproduce the problem anymore. Thanks!