322753 – It should be possible to disable the override indicator

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 322753 - It should be possible to disable the override indicator

Summary: It should be possible to disable the override indicator

Status:	RESOLVED FIXED

Alias:	None

Product:	CDT
Classification:	Tools
Component:	cdt-editor (show other bugs)
Version:	8.0
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	8.0
Assignee:	Anton Leherbauer
QA Contact:	Anton Leherbauer

URL:
Whiteboard:
Keywords:

Depends on:	320561
Blocks:
	Show dependency tree

Reported:	2010-08-16 03:57 EDT by Anton Leherbauer
Modified:	2010-09-24 02:44 EDT (History)
CC List:	3 users (show)

See Also:

Attachments
Disable override indicator (4.56 KB, patch) 2010-09-17 23:46 EDT, Marc-André Laperle	no flags	Details \| Diff
Disable override indicator (5.22 KB, patch) 2010-09-17 23:51 EDT, Marc-André Laperle	aleherb+eclipse: iplog+	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Anton Leherbauer

2010-08-16 03:57:53 EDT

Computing the override indicator has an impact on performance, therefore it should be possible to disable it.

JDT does this by checking the visibility preferences of the override indicator annotation type.

Comment 1 Marc-André Laperle

2010-09-17 23:46:05 EDT

Created attachment 179162 [details]
Disable override indicator

Patch inspired by JDT. I had to change ASTProvider.WAIT_NO to ASTProvider.WAIT_ACTIVE_ONLY so that the changes would be applied immediately.

Comment 2 Marc-André Laperle

2010-09-17 23:51:41 EDT

Created attachment 179163 [details]
Disable override indicator

Also copied the comments.

Comment 3 Anton Leherbauer

2010-09-23 08:11:46 EDT

Thanks, I have committed the patch to HEAD with 2 minor changes:
- Don't request an AST on createPartControl
- Use flag ASTProvider.WAIT_NO instead of ASTProvider.WAIT_ACTIVE_ONLY

This is to avoid blocking the UI while computing an AST or waiting for it.

Comment 4 CDT Genie

2010-09-23 08:23:01 EDT

*** cdt cvs genie on behalf of aleherbau ***
Bug 322753 - It should be possible to disable the override indicator
Patch from Marc-Andre Laperle

[*] OverrideIndicatorManager.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt-core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/editor/OverrideIndicatorManager.java?root=Tools_Project&r1=1.2&r2=1.3
[*] CEditor.java 1.219 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt-core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/editor/CEditor.java?root=Tools_Project&r1=1.218&r2=1.219

Comment 5 Marc-André Laperle

2010-09-23 12:33:00 EDT

(In reply to comment #3)
> - Use flag ASTProvider.WAIT_NO instead of ASTProvider.WAIT_ACTIVE_ONLY

What I'm seeing is that it's possible to enable the override indicators then apply and the indicators do not appear.

Comment 6 Anton Leherbauer

2010-09-24 02:44:15 EDT

(In reply to comment #5)
> (In reply to comment #3)
> > - Use flag ASTProvider.WAIT_NO instead of ASTProvider.WAIT_ACTIVE_ONLY
> 
> What I'm seeing is that it's possible to enable the override indicators then
> apply and the indicators do not appear.

Right, this can happen when the indexer is running.  In this case the override markers would appear as soon as the indexer has finished.
On the other hand, this is quite unintuitive.  I think we should update immediately.  The override indicators might be incomplete in this case (because of the incomplete index), but this will be fixed when the index has been updated.
I changed the flag back to WAIT_ACTIVE_ONLY.