Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 322676 - SourceLookupTab, CommonTab and EnvironmentTab reference Java in context help
Summary: SourceLookupTab, CommonTab and EnvironmentTab reference Java in context help
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7 M2   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-13 13:06 EDT by Michael Rennie CLA
Modified: 2011-05-26 14:50 EDT (History)
2 users (show)

See Also:
pawel.1.piech: review+

Attachments
proposed fix (6.54 KB, patch)
2010-08-13 13:06 EDT, Michael Rennie CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2010-08-13 13:06:23 EDT 
Created attachment 176570 [details]
proposed fix

code from HEAD

All of the mentioned tabs reference Java-specific help topics in their context help, which is not appropriate in non-Java usages (obviously).

We should provide a way for consumers to hook in their own help context ids to the tabs. One way would be to add setHelpContextid(String) and a getHelpContextId() this way we would not break the noextend API contract on the three tabs.

The attached patch provides the mentioned methods in AbstractLaunchConfigurationTab, and provides a default set* call within each of the three tabs.
Comment 1 Darin Wright CLA 2010-08-16 13:32:06 EDT 
Applied. Added additional comments to state that not all tabs honor the context help setting, and doc to the Common, Env, and Source Lookup tabs to state that they do honor the setting.

We should probably offer generic help for the Common and Evnvironment tabs that does not refer to Java debugging (but there is another bug for separating the platform and JDT debug doc).
Comment 2 Darin Wright CLA 2010-08-16 13:32:22 EDT 
Fixed.
Comment 3 Pawel Piech CLA 2011-05-06 18:20:40 EDT 
Reviewed.