Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 322653 - Refactor data set editor pages' codes[28817]
Summary: Refactor data set editor pages' codes[28817]
Status: RESOLVED WORKSFORME
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: BIRT (show other bugs)
Version: 2.5.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7.0   Edit
Assignee: Birt-Data-inbox@eclipse.org CLA
QA Contact:
URL:
Whiteboard: Obsolete
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-13 09:35 EDT by Xiaoxiao Wu CLA
Modified: 2013-04-19 13:13 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xiaoxiao Wu CLA 2010-08-13 09:35:08 EDT 
Build Identifier: 20100810

Refactor data set editor pages' codes.

Reproducible: Always
Comment 1 Mingxia Wu CLA 2010-10-25 23:20:03 EDT 
Mark it worksForMe.
Comment 2 Jesse Weinstein CLA 2013-04-18 14:46:23 EDT 
There was a checkin referring to this bug, here: https://git.eclipse.org/c/birt/org.eclipse.birt.git/commit/?id=76586f2a920d7ff9cbb417afa90e7f165e2bb83a

I don't understand how the checkin is related to the (very limited) bug report. Could someone clarify?
Comment 3 Jesse Weinstein CLA 2013-04-18 14:49:43 EDT 
I've CC'ed Lin Zhu, who made the commit, on this bug -- hopefully they can clarify.
Comment 4 Xiaoxiao Wu CLA 2013-04-18 23:56:10 EDT 
Hi Jesse,

Actually the checkin made in 2010 was to fix an UI issue in data set editor when doing code refactoring.

The modified file PropertyPageWrapper.java serves all the oda data sets. At that time, we found an UI issue that when the data set query page is in an invalid state, e.g. missing some requirement attributes to define the query text, users will be disallowed to leave the query page or navigating to another data set build-in page such as data set filters page. Then we decided to enhance the UI behaviors to let users leave the data set page anyway, as we though it would be more user-friendly.
Therefore you could see the changes of codes in PropertyPageWrapper.java.

If you have anything still confused, please feel free to contact us.

Thanks,
Xiaoxiao
Comment 5 Jesse Weinstein CLA 2013-04-19 13:13:45 EDT 
Thanks for clarifying -- that is the effect of the change, I agree. I understand that it was reverted sometime between 4.3M5 and 4.3M6 -- do you know the bugzilla entry where that happened?

Also, since there was a commit made under this bugzilla entry, shouldn't the resolution be something like "FIXED" rather than "WORKSFORME" (which, AFAIK, implies that the report couldn't be reproduced, and so was otherwise ignored)?