Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 322615 - New JavaServer Faces (JSF) Page (xhtml, xml syntax) template has ISO-8859-1 hard-coded instead of ${encoding}
Summary: New JavaServer Faces (JSF) Page (xhtml, xml syntax) template has ISO-8859-1 h...
Status: RESOLVED FIXED
Alias: None
Product: Java Server Faces
Classification: WebTools
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.2.2   Edit
Assignee: Gerry Kessler CLA
QA Contact:
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-12 22:45 EDT by Jesse Viviano CLA
Modified: 2010-08-27 14:35 EDT (History)
2 users (show)

See Also:
raghunathan.srinivasan: pmc_approved? (david_williams)
raghunathan.srinivasan: pmc_approved? (naci.dai)
raghunathan.srinivasan: pmc_approved? (deboer)
raghunathan.srinivasan: pmc_approved? (neil.hauge)
raghunathan.srinivasan: pmc_approved? (kaloyan)
raghunathan.srinivasan: pmc_approved+
raghunathan.srinivasan: review+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Viviano CLA 2010-08-12 22:45:23 EDT
Build Identifier: 20100617-1415

I noticed that the New JavaServer Faces (JSF) Page (xhtml, xml syntax) template has ISO-8859-1 hard-coded into the template instead of having ${encoding} where the encoding is specified. This is inconvenient who have set their default encoding to UTF-8 or their local encoding standard (e.g. an author could use Shift-JIS or UTF-8 for Japanese text, but will get mojibake served up if the encoding is set to ISO-8859-1).

Reproducible: Always

Steps to Reproduce:
1.Right click and hold on any dynamic web project's root node or the WebContent
folder for that project in the project explorer.
2.A menu appears.
3.Select New->JSP File.
4.Give any name ending in .jsp in the file name line.
5.Click the Next button.
6.Click New JavaServer Faces (JSF) Page (xhtml, xml syntax) in the template list.
7.You will notice that ISO-8859-1 is hard-coded where ${encoding} should be located.
Comment 1 Gerry Kessler CLA 2010-08-24 13:34:45 EDT
Checked into HEAD (3.2.2 and 3.3)
Comment 2 Gerry Kessler CLA 2010-08-24 13:35:57 EDT
_
Comment 3 Raghunathan Srinivasan CLA 2010-08-27 14:34:41 EDT
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug"
(requested by an adopter) please document it as such. 
See description
* Is there a work-around? If so, why do you believe the work-around is
insufficient? 
None
* How has the fix been tested? Is there a test case attached to the bugzilla
record? Has a JUnit Test been added? 
Manual
* Give a brief technical overview. Who has reviewed this fix? 
See description
* What is the risk associated with this fix? 
none-low
Comment 4 Raghunathan Srinivasan CLA 2010-08-27 14:35:05 EDT
This failed to make this week's build because of spurious junit failures in
local testing.