Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 322605 - Extract local variable refactoring in an aspect complains about non-existant problems
Summary: Extract local variable refactoring in an aspect complains about non-existant ...
Status: RESOLVED FIXED
Alias: None
Product: AJDT
Classification: Tools
Component: Core (show other bugs)
Version: 2.1.0   Edit
Hardware: Macintosh Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 2.1.1   Edit
Assignee: Andrew Eisenberg CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-12 19:40 EDT by Andrew Eisenberg CLA
Modified: 2010-08-19 15:46 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Eisenberg CLA 2010-08-12 19:40:14 EDT 
Simple aspect. Select '9 + 8' and perform 'Extract Local' refactoring.

public aspect ExtractLocal {
   void x() {
	   int x = 9 + 8;
   }
}


Numerous refactoring problems are found.  This is because validation is proceeding off of the actual source code, not the transformed source code.  See ExtractTempRefactoring.checkFinalConditions() line 498.
Comment 1 Andrew Eisenberg CLA 2010-08-12 19:48:03 EDT 
Extract method appears to work.
Comment 2 Andrew Eisenberg CLA 2010-08-12 23:18:43 EDT 
The easiest fix here would be to call ExtractTempRefactoring.setCheckResultForCompileProblems(false).  This would have to be done through weaving.
Comment 3 Andrew Eisenberg CLA 2010-08-19 15:46:07 EDT 
Fixed.