Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 322543 - [clean up] Stops working after 100 problems in one CU
Summary: [clean up] Stops working after 100 problems in one CU
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7 M2   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 325195
  Show dependency tree
 
Reported: 2010-08-12 10:44 EDT by Markus Keller CLA
Modified: 2010-09-16 05:08 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2010-08-12 10:44:52 EDT 
HEAD

Clean Ups like "Add missing Override annotations" stop working after 100 problems in one CU.

Problem is most probably that the compiler only reports the first 100 problems. That makes sense in the Java editor and for batch compilations, but refactorings and clean ups should see all problems.

Possible fix is to add

    options.put(JavaCore.COMPILER_PB_MAX_PER_UNIT, "0"); //$NON-NLS-1$

in RefactoringASTParser#getCompilerOptions(IJavaElement).
Comment 1 Markus Keller CLA 2010-09-09 05:24:19 EDT 
Rajesh, can you please write a new test for this? Something like CleanUpTest#testAddOverride15(), but where you generate 200 methods in a loop. The test should fail in HEAD but become green with the fix in comment 0.
Comment 2 Markus Keller CLA 2010-09-13 07:02:56 EDT 
> Possible fix is to add
> 
>     options.put(JavaCore.COMPILER_PB_MAX_PER_UNIT, "0"); //$NON-NLS-1$
> 
> in RefactoringASTParser#getCompilerOptions(IJavaElement).

I've released that to HEAD for 3.7 M2.
Comment 3 Dani Megert CLA 2010-09-14 02:31:16 EDT 
(In reply to comment #1)
> Rajesh, can you please write a new test for this? Something like
> CleanUpTest#testAddOverride15(), but where you generate 200 methods in a loop.
> The test should fail in HEAD but become green with the fix in comment 0.
Filed bug 325195 for the test.
Comment 4 Dani Megert CLA 2010-09-16 05:08:29 EDT 
Verified in I20100915-2024.