Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 322541 - Commit is enabled when in state rebasing
Summary: Commit is enabled when in state rebasing
Status: CLOSED WORKSFORME
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-12 10:40 EDT by Stefan Lay CLA
Modified: 2010-08-12 10:57 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Lay CLA 2010-08-12 10:40:57 EDT 
When the repository state is Rebase I can nevertheless commit. The result is strange. A new commit is created but the state is still "rebase".

The root cause is that the JGit RepositoryState REBASING_REBASING returns true in the merhod canCommit. It has to be clarified if this is correct.
Comment 1 Stefan Lay CLA 2010-08-12 10:57:13 EDT 
Wrote a mail to http://dev.eclipse.org/mhonarc/lists/jgit-dev/msg00541.html

Shawn: Nope, its correct.  You can make (or amend) a commit during rebase.