Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 322493 - [Content Assist] html tag proposal is missing in case of prefix
Summary: [Content Assist] html tag proposal is missing in case of prefix
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.html (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.2.2   Edit
Assignee: Rakesh CLA
QA Contact: Nick Sandonato CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-12 05:32 EDT by Roy Ganor CLA
Modified: 2010-08-25 15:06 EDT (History)
2 users (show)

See Also:
nsand.dev: review+

Attachments
patch (4.39 KB, patch)
2010-08-25 12:54 EDT, Rakesh CLA 		nsand.dev: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roy Ganor CLA 2010-08-12 05:32:28 EDT 
One of our users mentioned in a post that when having a prefix of a tag the tag is not provided.

Example:
1. create a new empty html file
2. hit Ctrl+Space - see that <html> tag proposal is provided
3. exit the content assist mode and write in the file "<ht"
4. hit again ctrl+space 

The user expectation was to get <html> tag proposal 

current - no proposals are provided
Comment 1 Rakesh CLA 2010-08-25 12:54:14 EDT 
Created attachment 177442 [details]
patch

Whenever document is completely empty addEmptyDocumentProposals() is called, which computes all these proposals. As soon as we type something document is not empty, thats why we don't see any proposal.If we can treat document without DocType as empty then this small patch works .If we want to deal with document without doctype as separate , then we may need to do large(relatively) change for a infrequent scenario.Let me know if i should take second approach.
Comment 2 Nick Sandonato CLA 2010-08-25 15:06:26 EDT 
Changes look good. Thanks, Rakesh.