Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 322449 - overload for TaskUiInternal.createAndOpenNewTask
Summary: overload for TaskUiInternal.createAndOpenNewTask
Status: CLOSED INVALID
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: dev   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Kilian Matt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-11 20:11 EDT by Kilian Matt CLA
Modified: 2011-02-01 22:09 EST (History)
3 users (show)

See Also:


Attachments
Patch, which adds the overload (1.13 KB, patch)
2010-08-11 20:12 EDT, Kilian Matt CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kilian Matt CLA 2010-08-11 20:11:03 EDT
The method TaskUiInternal.createAndOpenNewTask(TaskData taskData) creates a new outgoing task by calling TasksUiUtil.createOutgoingNewTask. 
For more flexibility there should be an overloaded method, which accepts also a ITask parameter.
Comment 1 Kilian Matt CLA 2010-08-11 20:12:53 EDT
Created attachment 176426 [details]
Patch, which adds the overload
Comment 2 Steffen Pingel CLA 2010-08-17 23:19:20 EDT
I am a bit worried that this change enables creation of a task that does not match the task data that is passed to TaskUiInternal.createAndOpenNewTask(). I would prefer if TaskDataManager.saveWorkingCopy() would fire an event instead similar to TaskDataManager.putUpdatedTaskData(). Would that also work for you?
Comment 3 Steffen Pingel CLA 2011-01-04 14:27:08 EST
Kilian, any thought on my last comment?
Comment 4 Kilian Matt CLA 2011-01-04 18:50:44 EST
As I've changed the structure of the review storage quite a bit I don't need that overload anymore, so I would recommend to close this issue.