Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 322439 - [Intro] Platform UI changes to support intro in Eclipse 4
Summary: [Intro] Platform UI changes to support intro in Eclipse 4
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.0   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 4.2 M5   Edit
Assignee: Platform UI Triaged CLA
QA Contact: Eric Moffatt CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 509374 322440
  Show dependency tree
 
Reported: 2010-08-11 17:28 EDT by Chris Goldthorpe CLA
Modified: 2021-02-01 07:59 EST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Goldthorpe CLA 2010-08-11 17:28:31 EDT 
Eclipse 4.0 does not support Intro, Intro needs to be supported for Eclipse 4.1. A separate bug will track the work in the UA component. The intro support must be backward compatible with intro configurations created in Eclipse 3.x.
Comment 1 Chris Goldthorpe CLA 2010-08-11 17:35:05 EDT 
Bug 322440 has been created to track the UA work.
Comment 2 Eric Moffatt CLA 2010-08-17 14:26:30 EDT 
I've commented on the other defect about what the shape of these changes would be...
Comment 3 Eric Moffatt CLA 2010-12-06 10:10:33 EST 
Changing milestone, at this point I expect to be able to host the existing Intro without change...
Comment 4 Eric Moffatt CLA 2011-11-25 11:37:24 EST 
Pushed in >20111125.

commit de3b05122fa80634221165f19a1cd3ae6401dffd

This is a start...the normal startup and 'standby' handling is done but now all operations work correctly. Specifically the 'Go to Workbench' (which creates a trim control for the welcome) is broken.
Comment 5 Eric Moffatt CLA 2011-11-28 11:04:05 EST 
It turns out that Intro's 'go to Workbench' code accesses the internal TrimManager class. For my money I'd prefer to just get rid of the code that makes the trim version of the Intro altogether and just have 'go to Workbench' set standby to true and close the Welcome view.

I've just tried most of the other operations and everything else seems to be OK on first look except for a known issue involving maximizing a stack outside the perspective stack when there is more than one perspective open.
Comment 6 Chris Goldthorpe CLA 2011-11-28 12:08:09 EST 
If I'm reading Comment 5 correctly the problem is in opening up the mini toolbar that is added to the trim when you press "Go to workbench". I would be 100% in support of removing that toolbar, I have never felt that it added much value and I don't think anyone would miss it.
Comment 7 Eric Moffatt CLA 2011-11-28 14:46:43 EST 
Chris, thanks for the input. After talking with McQ we think that perhaps the right solution (for both 3.x and 4.x) would be to switch from creating the specialized trim to instead *minimize* the Welcome view.

The logic is that the current behavior leaves the Welcome visible to the user (so they can restore it without having to 'know' to go to Help->Welcome. Minimizing the stack will have the same basic behavior...Welcome will still be open and in the trim.

What do you think ?
Comment 8 Eric Moffatt CLA 2011-12-05 13:27:16 EST 
For now I've hacked a 'fix' for this my providing a stub of ITrimManager, see bug 365625 for details...

Pushed in >20111205.

commit ae6a1ca03cd12e1b18924c02836c25fecc81eb0f
Comment 9 Eric Moffatt CLA 2011-12-09 13:10:08 EST 
Aggregate move to M5. Retarget to a different milestone if you wish...
Comment 10 Eric Moffatt CLA 2012-02-06 10:58:55 EST 
The current behavior is about as good as we can get for 4.2. I'll mark this as fixed, we can open new defects if any egregious defects are found...