Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 322426 - Add copy implementation to CPPASTAmbiguousTemplateArgument class.
Summary: Add copy implementation to CPPASTAmbiguousTemplateArgument class.
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-indexer (show other bugs)
Version: 7.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 7.0.1   Edit
Assignee: Vivian Kong CLA
QA Contact: Markus Schorn CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-11 15:55 EDT by John Liu CLA
Modified: 2010-08-11 21:23 EDT (History)
1 user (show)

See Also:

Attachments
a patch applied to cdt.core, cdt.core.test and cdt.core.lrparser (1.24 KB, text/plain)
2010-08-11 16:17 EDT, John Liu CLA 		no flags Details
an updated patch applied to cdt.core, cdt.core.lrparser and cdt.core.test (3.38 KB, patch)
2010-08-11 16:56 EDT, John Liu CLA 		vivkong: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Liu CLA 2010-08-11 15:55:39 EDT 
Build Identifier: 

Add copy implementation to CPPASTAmbiguousTemplateArgument class. 

Reproducible: Always
Comment 1 John Liu CLA 2010-08-11 16:17:49 EDT 
Created attachment 176397 [details]
a patch applied to cdt.core, cdt.core.test and cdt.core.lrparser

This is a problem found during the investigation of bug 321376, https://bugs.eclipse.org/bugs/show_bug.cgi?id=321376.
The patch adds a copy implementation to CPPASTAmbiguousTemplateArgument, updates a LR parser action class, CPPBuildASTParserAction.java and updates a test case, testBug311164() in AST2TemplateTests.java by adding a validation of the copied node.

I run junit tests for cdt core parser and lr parser in my workspace and the updated test case passes both suite.

This fix is to target 701, so I didn't update other ambiguous nodes for copy implementations, since they are not needed so far and I am reluctant to add such bunch of copy implementations in these ast nodes in 701, head stream maybe a good place to add them if we really need them.
Comment 2 John Liu CLA 2010-08-11 16:56:28 EDT 
Created attachment 176409 [details]
an updated patch applied to cdt.core, cdt.core.lrparser and cdt.core.test
Comment 3 Vivian Kong CLA 2010-08-11 17:08:24 EDT 
Applied to cdt_7_0 and HEAD.  Thanks.