Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 322397 - The entire module cache is destroyed if a publisher modified modules.
Summary: The entire module cache is destroyed if a publisher modified modules.
Status: CLOSED FIXED
Alias: None
Product: WTP ServerTools
Classification: WebTools
Component: wst.server (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.2   Edit
Assignee: Angel Vera CLA
QA Contact: Angel Vera CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-11 11:39 EDT by Troy Bishop CLA
Modified: 2010-08-25 16:25 EDT (History)
0 users

See Also:

Attachments
possible patch (3.27 KB, patch)
2010-08-11 11:41 EDT, Troy Bishop CLA 		arvera: iplog+
arvera: review+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Troy Bishop CLA 2010-08-11 11:39:48 EDT 
Build Identifier: WTP 3.2

If a publisher returns 'true' for PublisherDelegate#isModifyModules() then the entire publishing cache is destroyed, which means when the delta is requested it needs to be recomputed a second time.  If the application being published is large then this can turn into a rather bad publishing performance problem.  Attached is a patch which asks the PublisherDelegate to provide a list of the IModule's that it modified so that only the cache for those modules is cleared.

Reproducible: Always
Comment 1 Troy Bishop CLA 2010-08-11 11:41:04 EDT 
Created attachment 176369 [details]
possible patch
Comment 2 Angel Vera CLA 2010-08-25 16:10:15 EDT 
Changes committed to 32M
Comment 3 Angel Vera CLA 2010-08-25 16:12:33 EDT 
changes released to 32M
Comment 4 Angel Vera CLA 2010-08-25 16:23:45 EDT 
changes committed to HEAD (3.3)
Comment 5 Angel Vera CLA 2010-08-25 16:25:07 EDT 
changes released to HEAD(3.3)