Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 322278 - WSDLEditorUtil does not compile against Eclipse 4
Summary: WSDLEditorUtil does not compile against Eclipse 4
Status: VERIFIED FIXED
Alias: None
Product: WTP Webservices
Classification: WebTools
Component: wst.wsdl (show other bugs)
Version: 3.2.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3   Edit
Assignee: Valentin Baciu CLA
QA Contact: Keith Chong CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-10 15:30 EDT by Valentin Baciu CLA
Modified: 2010-08-20 14:17 EDT (History)
1 user (show)

See Also:

Attachments
Patch (2.29 KB, patch)
2010-08-10 15:34 EDT, Valentin Baciu CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Valentin Baciu CLA 2010-08-10 15:30:48 EDT 
Description	Resource	Path	Location	Type
The method getDefaultOrientation() is undefined for the type WorkbenchWindow	WSDLEditorUtil.java	/org.eclipse.wst.wsdl.ui/src-asd-wsdl11/org/eclipse/wst/wsdl/ui/internal/util	line 185	Java Problem
Comment 1 Valentin Baciu CLA 2010-08-10 15:31:30 EDT 
WSDLEditorUtil uses WorkbenchWindow#getDefaultOrientation() to determine the default window orientation. In Eclipse 4, WorkbenchWindow does not extend Window anymore and thus lacks said method.

It appears that Window#getDefaultOrientation is actually a static method and thus can and should be called directly.
Comment 2 Valentin Baciu CLA 2010-08-10 15:34:09 EDT 
Created attachment 176271 [details]
Patch
Comment 3 Valentin Baciu CLA 2010-08-10 15:47:08 EDT 
Fix committed and released to WTP 3.3 builds > v201008101945 UTC. wtpe4 builds should also pick up this fix because they compile against HEAD.
Comment 4 David Williams CLA 2010-08-10 15:54:25 EDT 
Thanks very much! I hop all our incompatibilities are this easy!
Comment 5 Valentin Baciu CLA 2010-08-20 14:17:12 EDT 
Closing.