Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 322272 - unable to inherit and successfully weave a declare anno from an abstract aspect
Summary: unable to inherit and successfully weave a declare anno from an abstract aspect
Status: RESOLVED FIXED
Alias: None
Product: AspectJ
Classification: Tools
Component: Compiler (show other bugs)
Version: DEVELOPMENT   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 1.6.10   Edit
Assignee: aspectj inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-10 15:08 EDT by Andrew Clement CLA
Modified: 2010-08-10 19:48 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Clement CLA 2010-08-10 15:08:31 EDT 
Discovered by Thomas Risberg.

multipart problem.

First problem is that BinaryTypeBindings deliberately discard synthetic methods when populating their method tables.  This means declare annotation is not processed (it is marked synthetic), since it is not there it cannot be found by the lookup code that wants to discover the annotation.
Comment 1 Andrew Clement CLA 2010-08-10 16:03:08 EDT 
step (1), make them non-synthetic

This then reveals the problem that we don't walk the hierarchy to find them.  If they aren't found on the concrete sub-aspect then we fail.  Added code to walk the hierarchy.  The walker code then had to be enhanced to allow that it may walk from a source artifact to a binary artifact.  Then had to allow for it encountering a parameterized type binding during the walk.

test cases added.
Comment 2 Andrew Clement CLA 2010-08-10 16:06:11 EDT 
one remaining issue I worry about...  users probably expect declare @type statements to be independent (not subject to overriding).  However, due to their representation as methods whose names have an int suffix, a subtype will override a super!!!!! raised as bug 322282
Comment 3 Andrew Clement CLA 2010-08-10 19:48:47 EDT 
test and fix committed