Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 322269 - StandaloneIndexerTask creates status with a wrong status code
Summary: StandaloneIndexerTask creates status with a wrong status code
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-indexer (show other bugs)
Version: 7.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 7.0.1   Edit
Assignee: Vivian Kong CLA
QA Contact: Markus Schorn CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-10 14:52 EDT by John Liu CLA
Modified: 2010-08-10 16:23 EDT (History)
1 user (show)

See Also:

Attachments
a patch applied to org.eclipse.cdt.internal.core.indexer.StandaloneIndexerTask (1.21 KB, text/plain)
2010-08-10 14:56 EDT, John Liu CLA 		no flags Details
a patch applied to org.eclipse.cdt.internal.core.indexer.StandaloneIndexerTask (copyright updated) (1.64 KB, patch)
2010-08-10 15:30 EDT, John Liu CLA 		vivkong: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Liu CLA 2010-08-10 14:52:48 EDT 
Build Identifier: 

This is a bug found during the investigation of the bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=321376

StandaloneIndexerTask creates exception status set IStatus.ERROR as the status code which collides with CCorePlugin.STATUS_PDOM_TOO_LARGE, so that it may report false exception for CCorePlugin.STATUS_PDOM_TOO_LARGE error.





Reproducible: Always
Comment 1 John Liu CLA 2010-08-10 14:56:01 EDT 
Created attachment 176265 [details]
a patch applied to org.eclipse.cdt.internal.core.indexer.StandaloneIndexerTask

The fix just remove the IStatus.ERROR from function's staus code argument, so the status is created by the default status code, the implementation is then consistent with CCorePlugin's implementation to the same functions.

The fix has been discussed with Markus in the bug, https://bugs.eclipse.org/bugs/show_bug.cgi?id=321376
Comment 2 John Liu CLA 2010-08-10 15:30:19 EDT 
Created attachment 176270 [details]
a patch applied to org.eclipse.cdt.internal.core.indexer.StandaloneIndexerTask (copyright updated)
Comment 3 Vivian Kong CLA 2010-08-10 15:44:05 EDT 
Applied to cdt_7_0 and HEAD.  Thanks John