322268 – CPPSemantics should check null for op2 in function findOverloadedOperator

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 322268 - CPPSemantics should check null for op2 in function findOverloadedOperator

Summary: CPPSemantics should check null for op2 in function findOverloadedOperator

Status:	RESOLVED FIXED

Alias:	None

Product:	CDT
Classification:	Tools
Component:	cdt-indexer (show other bugs)
Version:	7.0
Hardware:	PC Windows XP

Importance:	P3 normal (vote)
Target Milestone:	7.0.1
Assignee:	Vivian Kong
QA Contact:	Markus Schorn

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2010-08-10 14:31 EDT by John Liu
Modified:	2010-08-10 16:23 EDT (History)
CC List:	1 user (show)

See Also:	321376

Attachments
a patch applied to org.eclipse.cdt.internal.core.dom.parser.cpp.semantics.CPPSemantics (1.04 KB, patch) 2010-08-10 14:36 EDT, John Liu	vivkong: iplog+	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description John Liu

2010-08-10 14:31:56 EDT

Build Identifier: 

A bug found during the investigation for bug 321736
The function of findOverloadedOperator in class CPPSemantics should check if
the op2 is null since CPPASTBinaryExpression could return null by its
getOperand2 function.



Reproducible: Always

Comment 1 John Liu

2010-08-10 14:36:47 EDT

Created attachment 176263 [details]
a patch applied to org.eclipse.cdt.internal.core.dom.parser.cpp.semantics.CPPSemantics

I have discussed the fix patch with Markus in the bug 321376, https://bugs.eclipse.org/bugs/show_bug.cgi?id=321376

The patch targets CDT 701 and I will also create a junit test case for this patch.

Comment 2 Vivian Kong

2010-08-10 15:41:58 EDT

Applied to cdt_7_0 and HEAD.  Thanks John

Comment 3 CDT Genie

2010-08-10 16:23:04 EDT

*** cdt cvs genie on behalf of vkong ***
Bug 322268 CPPSemantics should check null for op2 in function findOverloadedOperator

[*] CPPSemantics.java 1.164.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/CPPSemantics.java?root=Tools_Project&r1=1.164.2.1&r2=1.164.2.2

[*] CPPSemantics.java 1.170 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/CPPSemantics.java?root=Tools_Project&r1=1.169&r2=1.170