Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 322239 - Error - 7 icon(s) not replaced in ....
Summary: Error - 7 icon(s) not replaced in ....
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Buckminster (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: buckminster.core-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-10 10:33 EDT by Flavio Donze CLA
Modified: 2019-02-25 14:41 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Flavio Donze CLA 2010-08-10 10:33:52 EDT 
Build Identifier: Build id: I20100608-0911

I'm using Buckminster to automate my builds. I get the following error:

Error - 7 icon(s) not replaced in C:\WINDOWS\TEMP\p2.brandingIron705967665982685683\launcher.exe using C:\Programme\Hudson\workspace\jobs\scodi.client.integration\workspace\source\scodi-rcp\features\ch.scodi.client.feature\ch.scodi.scodi4p\icons\scodi.ico

The path is put together wrong "features\ch.scodi.client.feature" is the location of the feature where the product file is located.
"ch.scodi.scodi4p\icons\scodi.ico" is the branding plug-in and the path defined in the product file.
The build somehow uses the wrong base path.

Using the export wizard in the eclipse IDE the launcher icon is made correctly.

Reproducible: Always
Comment 1 yanamon CLA 2010-10-05 16:50:15 EDT 
I am seeing this problem as well and it appears to be a a problem with how org.eclipse.equinox.internal.p2.publisher.eclipse.ProductFile attempts to resolve files within a buckminster workspace.  In the addIcon method it is attempting to resolve paths that are not absolute by concatenating the workspace directory and the relative path together.  Even if the plugins has been resolved to the workspace directory the icon path will not be found because buckminster does not put plugins in the root workspace directory.  After that fails it just concatenates the relative path with the plugin that defined the product which also doesn't work.
Comment 2 Flavio Donze CLA 2012-11-20 10:51:51 EST 
This issue seems to be fixed in the current buckminster version:
Eclipse 4.2.1
org.eclipse.buckminster.core_1.3.0.v20120910-1329