Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 322153 - [RemoteSrvs][Quotes] Quotes example depends on Github code, Code may not be CQed
Summary: [RemoteSrvs][Quotes] Quotes example depends on Github code, Code may not be CQed
Status: RESOLVED FIXED
Alias: None
Product: ECF
Classification: RT
Component: ecf.examples (show other bugs)
Version: 3.3.0   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Markus Kuppe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-09 12:15 EDT by Markus Kuppe CLA
Modified: 2010-11-02 04:54 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Kuppe CLA 2010-08-09 12:15:14 EDT
org.eclipse.ecf/examples/bundles/org.eclipse.ecf.examples.remoteservices.quotes.consumer depends on a bundle hosted at Github [0]. So far we have avoided dependencies towards non CQed code.
Additionally quotes.consumers contains a com.remainsoftware.osgilloscope_0.1.0.jar. Has this code been CQed? A solution might be to move org.eclipse.ecf.examples.remoteservices.quotes.* to Github.

Markus

[0] http://github.com/ECF/Newsreader/tree/master/bundles/org.eclipse.ecf.services.quotes/
Comment 1 Markus Kuppe CLA 2010-08-09 12:25:21 EDT
Btw. /org.eclipse.ecf.examples.remoteservices.quotes.consumer/projectSet.psf still points to the non-existing ecf1.osuosl.org CVS repo.
Comment 2 Scott Lewis CLA 2010-08-09 13:07:27 EDT
(In reply to comment #0)
> org.eclipse.ecf/examples/bundles/org.eclipse.ecf.examples.remoteservices.quotes.consumer
> depends on a bundle hosted at Github [0]. So far we have avoided dependencies
> towards non CQed code.
> Additionally quotes.consumers contains a
> com.remainsoftware.osgilloscope_0.1.0.jar. Has this code been CQed? A solution
> might be to move org.eclipse.ecf.examples.remoteservices.quotes.* to Github.
> 
> Markus
> 
> [0]
> http://github.com/ECF/Newsreader/tree/master/bundles/org.eclipse.ecf.services.quotes/


Adding Wim Jongman to this bug...as I believe o.e.e.examples.remoteservices.quotes and consumer are contributions from Wim/Remain Software, and they will have to decide on appropriate strategy for dealing with this issue.  My suggestion:  move this example code to github if dependencies on non-CQ'd code cannot be easily removed.
Comment 3 Markus Kuppe CLA 2010-08-09 13:11:11 EDT
(In reply to comment #2)
> My suggestion:  move this example code to github if
> dependencies on non-CQ'd code cannot be easily removed.

Just wanted to add that if you do so, file a bug with the webmasters to remove the two projects from CVS too so that they are completely removed from history.
Comment 4 Wim Jongman CLA 2010-08-16 03:17:38 EDT
(In reply to comment #3)
> (In reply to comment #2)
> > My suggestion:  move this example code to github if
> > dependencies on non-CQ'd code cannot be easily removed.
> 
> Just wanted to add that if you do so, file a bug with the webmasters to remove
> the two projects from CVS too so that they are completely removed from history.

I can move the quote service code to Eclipse or move the Example to Github, it is all my code. I think having sufficient examples is important. However, there are already remote services examples so this might be considered redundant.

The nice thing about this example is that it uses some kind of "real" service.

I am in favor of moving all to Eclipse because of visibility.


PS
We could create a new repository "services" that holds some usable "remote" services like the quotes service. We could then also add other trivial and non-trivial services in the future.
Comment 5 Markus Kuppe CLA 2010-08-16 04:22:41 EDT
(In reply to comment #4)

> I can move the quote service code to Eclipse or move the Example to Github, it
> is all my code. I think having sufficient examples is important. However, there
> are already remote services examples so this might be considered redundant.
> 
> The nice thing about this example is that it uses some kind of "real" service.
> 
> I am in favor of moving all to Eclipse because of visibility.

If the code ownership is your, I'm +1 for moving the code to eclipse.org too.

> PS
> We could create a new repository "services" that holds some usable "remote"
> services like the quotes service. We could then also add other trivial and
> non-trivial services in the future.

I suggest we postpone this until we start restructuring the repo as part of the git move. Moving folders in CVS just sucks.
Comment 6 Wim Jongman CLA 2010-08-16 06:59:10 EDT
The quote services will be the first services and they are not yet checked in so this should be possible now.
Comment 7 Markus Kuppe CLA 2010-11-02 04:54:09 EDT
Moved code from git.eclipse.org to Newsreader project on Github