Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 322112 - Custom library directory of EAR not reflected in the project explorer view
Summary: Custom library directory of EAR not reflected in the project explorer view
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P3 minor (vote)
Target Milestone: 3.2.2   Edit
Assignee: Kaloyan Raev CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-09 04:36 EDT by Fred Bricon CLA
Modified: 2010-08-16 10:08 EDT (History)
1 user (show)

See Also:
cbridgha: review+

Attachments
Test project, using /APP-INF/lib as a custom library directory. (2.23 KB, application/zip)
2010-08-09 04:39 EDT, Fred Bricon CLA 		no flags Details
Screenshot (88.36 KB, image/jpeg)
2010-08-09 04:43 EDT, Fred Bricon CLA 		no flags Details
patch (6.14 KB, patch)
2010-08-11 11:04 EDT, Kaloyan Raev CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fred Bricon CLA 2010-08-09 04:36:49 EDT 
Build Identifier: 20100617-1415

If you modify the library directory of an Ear project (>= 5.0), from /lib to say /APP-INF/lib, The project explorer view still displays /lib as the library directory. 

Looks like the value is hardcoded, instead of reading it from the project settings.

regards,

Fred Bricon

PS: Helios JavaEE tools updated to 
Eclipse Java EE Developer Tools
Version: 3.2.1.v201006240600-7b7GHYKFSK2WBLPnDskt-bYEOrRh
Build id: 20100730021206


Reproducible: Always

Steps to Reproduce:
1. Create an ear project
2. right-click on the project > Properties > Deployment Assembly : change Ear library directory value to /APP-INF/lib or whatever, click ok 
3. Check the deployment descriptor node, library directory in the project explorer view, it should display your custom value but instead, still shows /lib
Comment 1 Fred Bricon CLA 2010-08-09 04:39:56 EDT 
Created attachment 176133 [details]
Test project, using /APP-INF/lib as a custom library directory.
Comment 2 Fred Bricon CLA 2010-08-09 04:43:10 EDT 
Created attachment 176135 [details]
Screenshot
Comment 3 Carl Anderson CLA 2010-08-10 14:02:51 EDT 
Kaloyan, this would be great to get fixed in WTP 3.2.2, but I am targetting it to 3.3 for now.  Feel free to retarget (and reassign) as appropriate.
Comment 4 Kaloyan Raev CLA 2010-08-11 11:04:59 EDT 
Created attachment 176363 [details]
patch

Fred, thanks for catching this. It was indeed forgotten as hard-coded.
Comment 5 Kaloyan Raev CLA 2010-08-11 11:05:35 EDT 
Chuck, please review the attached patch for 3.2.2.
Comment 6 Chuck Bridgham CLA 2010-08-11 16:30:12 EDT 
approved
Comment 7 Fred Bricon CLA 2010-08-11 18:51:28 EDT 
Thanks for the fix Kaloyan. 
Have you tried to search for "/lib" in the rest of WTP's codebase? Just to make sure there are no undesired leftovers.

regards,

Fred Bricon
Comment 8 Kaloyan Raev CLA 2010-08-16 10:08:23 EDT 
Committed to HEAD and released to 3.2 and 3.3 build.
Comment 9 Kaloyan Raev CLA 2010-08-16 10:08:54 EDT 
(In reply to comment #7)
> Thanks for the fix Kaloyan. 
> Have you tried to search for "/lib" in the rest of WTP's codebase? Just to make
> sure there are no undesired leftovers.
> 
> regards,
> 
> Fred Bricon

Thanks for reminding, Fred. I've just checked - there are no leftovers.