Comment 1 Artur Kronenberg 2010-09-17 10:44:33 EDT

Created attachment 179121 [details]
Outline for Libraries and web.xml

This is the patch for the outline:

I did not know what you mean by contents of the lib files and I am not sure if it would make sense to show them since in the editor there is no way of editing them. So I do not show them. I created two categories. Also, the selection is working, so if clicking in the outline, the element in the editor is selected.

for the xml:
I did the changes like in the Manifest editors. In PDE it seems, that sourcePages have their own outlines, so when you are in the configuration or in the overview tab of the editor, the xml is not shown in the outline. (For comparison, take a look at the Manifest editor outline - the plugin.xml e.g. is not shown there).
For the outline of the web.xml I used the integrated parse mechanisms of PDE. Their parser remembers the offsets and lengths of the elements, so selecting is straight forward and works.

Have fun testing. 

-- artur

Comment 2 Holger Staudacher 2010-09-22 14:24:59 EDT

Created attachment 179398 [details]
edited version of the initial patch

Hi Artur,
thanks for the patch. I reviewed your changes. Most times your outline works. I added a cleaned up version (fomating and so on). The functionality fails in the following scenario:

1) create a war product
2) switch to conf page
3) select servletbridge in the outline
4) add a file to the project called test.jar
5) add the test.jar to the libraries
6) see the outline failing ;)

Please use the new patch to fix this problem.

Regards Holger

Comment 3 Artur Kronenberg 2010-09-27 07:15:55 EDT

Created attachment 179621 [details]
Patch for war product outline

Fixed the problem you found in the earlier patch. I tested adding/removing so I hope everything works just fine now. 
Also, I added sorting for the libraries to the outline so now they are in the same order like in the editor page (forgot that the last time).

Comment 4 Holger Staudacher 2011-01-17 03:05:56 EST

I applied you patch and submitted the changes to CVS HEAD. Good job!

Comment 5 Artur Kronenberg 2011-01-26 10:45:10 EST

Hi,

you're welcome, it was fun writing it. Due to the move to libra:

I accept that the WAR Products can move to the Eclipse libra project including my contribution with this bug. Additional I can confirm the following:

1. I authored 100% of the content of the attached patch
2. I had the rights to contribute the content to Eclipse
3. I contributed the content under the EPL

Regards,
Artur

Comment 6 Kaloyan Raev 2011-08-24 09:57:14 EDT

Closing