Community
Participate
Working Groups
Created attachment 176095 [details] change occurrences of ipAddress to instrPtrAddress rationale: ipAddress commonly refers to "internet protocol" address, and caused confusion initially when attempting to debug 321186. has been filed as a separate bug so that 321186 patches can be more clutter free. NOTE: attached patch will require commit of 321186 patch before this patch can be fully applied.
For readability I think we should just go ahead and spell out "Instruction". If OK with you I'll change before committing.
(In reply to comment #1) > For readability I think we should just go ahead and spell out "Instruction". If > OK with you I'll change before committing. i'm ok with using "Instruction" in the changes you suggest.
Committed to HEAD.
*** cdt cvs genie on behalf of kryall *** Bug 322055 - edc - readability refactoring - change ipAddress to instrPtrAddress [*] ARMStack.java 1.6 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/edc/org.eclipse.cdt.debug.edc.arm/src/org/eclipse/cdt/debug/edc/internal/arm/ARMStack.java?root=Tools_Project&r1=1.5&r2=1.6 [*] X86Stack.java 1.8 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/edc/org.eclipse.cdt.debug.edc.x86/src/org/eclipse/cdt/debug/edc/x86/X86Stack.java?root=Tools_Project&r1=1.7&r2=1.8 [*] RunControl.java 1.29 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/edc/org.eclipse.cdt.debug.edc/src/org/eclipse/cdt/debug/edc/internal/services/dsf/RunControl.java?root=Tools_Project&r1=1.28&r2=1.29 [*] Snapshot.java 1.11 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/edc/org.eclipse.cdt.debug.edc/src/org/eclipse/cdt/debug/edc/internal/snapshot/Snapshot.java?root=Tools_Project&r1=1.10&r2=1.11 [*] DwarfFrameRegisterProvider.java 1.5 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/edc/org.eclipse.cdt.debug.edc/src/org/eclipse/cdt/debug/edc/internal/symbols/dwarf/DwarfFrameRegisterProvider.java?root=Tools_Project&r1=1.4&r2=1.5 [*] DwarfFrameRegisters.java 1.5 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/edc/org.eclipse.cdt.debug.edc/src/org/eclipse/cdt/debug/edc/internal/symbols/dwarf/DwarfFrameRegisters.java?root=Tools_Project&r1=1.4&r2=1.5 [*] MemoryVariableLocation.java 1.9 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/edc/org.eclipse.cdt.debug.edc/src/org/eclipse/cdt/debug/edc/internal/symbols/MemoryVariableLocation.java?root=Tools_Project&r1=1.8&r2=1.9 [*] VariableWithValue.java 1.10 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/edc/org.eclipse.cdt.debug.edc/src/org/eclipse/cdt/debug/edc/internal/eval/ast/engine/instructions/VariableWithValue.java?root=Tools_Project&r1=1.9&r2=1.10 [*] EvaluateID.java 1.12 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/edc/org.eclipse.cdt.debug.edc/src/org/eclipse/cdt/debug/edc/internal/eval/ast/engine/instructions/EvaluateID.java?root=Tools_Project&r1=1.11&r2=1.12 [*] Stack.java 1.29 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/edc/org.eclipse.cdt.debug.edc/src/org/eclipse/cdt/debug/edc/services/Stack.java?root=Tools_Project&r1=1.28&r2=1.29