Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 322052 - edc JUnit test TestLocalScopes1 relying on incorrect visibility bug in one case
Summary: edc JUnit test TestLocalScopes1 relying on incorrect visibility bug in one case
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-edc (show other bugs)
Version: 7.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 8.0   Edit
Assignee: Ken Ryall CLA
QA Contact: Ken Ryall CLA
URL:
Whiteboard:
Keywords:
Depends on: 322051
Blocks:
  Show dependency tree
 
Reported: 2010-08-07 12:26 EDT by Kirk Beitz CLA
Modified: 2012-05-22 14:45 EDT (History)
1 user (show)

See Also:


Attachments
change to TestDwarfReader.java to not contain the variable "m" as one of the expected variables at location 0x10a2a (comments updated as well) (1.41 KB, patch)
2010-08-07 12:26 EDT, Kirk Beitz CLA
cdtdoug: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kirk Beitz CLA 2010-08-07 12:26:53 EDT
Created attachment 176091 [details]
change to TestDwarfReader.java to not contain the variable "m" as one of the expected variables at location 0x10a2a (comments updated as well)

context: the test of variables acquired by getScopedVariables() at 68138 (a.k.a. 0x102a2) had been relying on the end of the broken end-of-scope testing of https://bugs.eclipse.org/bugs/show_bug.cgi?id=322051 .  

when tested properly, "m" should not appear when the cursor is sitting on the final brace of the function.

without https://bugs.eclipse.org/bugs/show_bug.cgi?id=322051, the tester probably saw the "m" when testing this, and incorrectly thought it was one of the variables to be counted when creating JUnitTest TestLocalScopes1.

careful examination of the resource files being tested, together with independent testing of the executable built and run under edc, demonstrates that the variable should not appear at the point at which the JUnit test is doing its examination.


attached fix:
- change to TestDwarfReader.java to not contain the variable m as one of the
  expected variables at location 0x10a2a (comments updated as well)
Comment 1 Ken Ryall CLA 2010-08-08 09:45:55 EDT
Committed to HEAD.
Comment 2 CDT Genie CLA 2010-08-08 10:23:04 EDT
*** cdt cvs genie on behalf of kryall ***
Bug 322052 -  edc JUnit test TestLocalScopes1 relying on incorrect visibility bug in one case

[*] TestDwarfReader.java 1.11 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/edc/org.eclipse.cdt.debug.edc.tests/src/org/eclipse/cdt/debug/edc/tests/TestDwarfReader.java?root=Tools_Project&r1=1.10&r2=1.11