Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 321981 - [Refactoring, Performance, Memory] Rewrite Node Model
Summary: [Refactoring, Performance, Memory] Rewrite Node Model
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 1.0.0   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: M4   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-06 08:59 EDT by Sebastian Zarnekow CLA
Modified: 2017-09-19 17:33 EDT (History)
0 users

See Also:
sebastian.zarnekow: indigo+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Zarnekow CLA 2010-08-06 08:59:47 EDT
The NodeContentAdapter is responsible for syncing the offset information in the node model when it's changed. This is implemented by means of an EContentAdapter although the only interesting notifier type is the CompositeNode. Furthermore, nobody should alter the node model anyway besides the partial parser - which we have under full control.

To get rid of the more or less expensive addNodeContentAdapter(rootNode) we should find another way to sync the offset information, e.g. by explicitly triggering a method like NodeContentAdapter#updateCompositeNode from the parser.

See also StackOverflowError when adding the NodeContentAdapter to a deep expression tree: https://build.eclipse.org/hudson/job/Xtext-nightly-HEAD/94/consoleText
Comment 1 Sebastian Zarnekow CLA 2010-11-25 16:21:26 EST
Pushed to master.
Comment 2 Karsten Thoms CLA 2017-09-19 17:21:51 EDT
Closing all bugs that were set to RESOLVED before Neon.0
Comment 3 Karsten Thoms CLA 2017-09-19 17:33:14 EDT
Closing all bugs that were set to RESOLVED before Neon.0