Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 321902 - Duplicate test classes should be renamed when they also contain duplicate function names
Summary: Duplicate test classes should be renamed when they also contain duplicate fun...
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Eclipselink (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Nobody - feel free to take it CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 321716
Blocks: 454799
  Show dependency tree
 
Reported: 2010-08-05 12:47 EDT by Michael OBrien CLA
Modified: 2022-06-09 10:25 EDT (History)
4 users (show)

See Also:

Attachments
difference between duplicate JUnitCriteriaSimpleTestSuite in jpa and modelgen (117.15 KB, patch)
2010-08-05 12:54 EDT, Michael OBrien CLA 		no flags Details | Diff
Merging eclipselink.jpa.modelgen.test into eclipselink.jpa.test (431.29 KB, patch)
2016-05-06 07:11 EDT, Petros Splinakis CLA 		petros.splinakis: review?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael OBrien CLA 2010-08-05 12:47:19 EDT 
>There are several test suites that have the same name in different packages with nearly exactly the same code
Even though this is allowed - it occassionally causes a waste of developer time when the wrong one is selected in the navigate/search menu of eclipse.
Also, there have been several other bugs involving UOW testing where the same test case is duplicated in 3 suites - but only 2 of the functions are fixed - where the 3rd remains and gets a secondary bug attached to it.

This will occur when both classes contain the same function name at nearly the same place

>See bug# 321716 as an example
org.eclipse.persistence.testing.tests.jpa.criteria.JUnitCriteriaSimpleTestSuite.simpleModTest():1796
org.eclipse.persistence.testing.tests.jpa.criteria.metamodel.JUnitCriteriaSimpleTestSuite.simpleModTest():1766
>are out of sync

>Fix: rename or merge the test suites
Comment 1 Michael OBrien CLA 2010-08-05 12:54:13 EDT 
Created attachment 175961 [details]
difference between duplicate JUnitCriteriaSimpleTestSuite in jpa and modelgen
Comment 2 Tom Ware CLA 2010-08-24 13:34:37 EDT 
Retargetting
Comment 3 Petros Splinakis CLA 2016-05-06 07:11:39 EDT 
Created attachment 261509 [details]
Merging eclipselink.jpa.modelgen.test into eclipselink.jpa.test
Comment 5 Eclipse Webmaster CLA 2022-06-09 10:25:37 EDT 
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink