Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 321898 - 3702a/3703 Button.java changes seems to be causing UI test failures
Summary: 3702a/3703 Button.java changes seems to be causing UI test failures
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.7   Edit
Hardware: PC Mac OS X
: P3 major (vote)
Target Milestone: 3.7 M1   Edit
Assignee: Scott Kovatch CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-05 12:06 EDT by Remy Suen CLA
Modified: 2010-08-06 07:31 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-08-05 12:06:04 EDT 
Working with 3702a as a base, I am seeing some recent changes for Button.java in HEAD that seems to be causing the test failures for I200804-1800.

http://download.eclipse.org/eclipse/downloads/drops/I20100804-1800/testresults/html/org.eclipse.ui.tests_macosx.cocoa.x86_5.0.html
Comment 1 Remy Suen CLA 2010-08-05 12:34:48 EDT 
Of course, that should've been 3702a/3703. :o
Comment 2 Silenio Quarti CLA 2010-08-05 12:46:22 EDT 
Scott, please investigate this for M1.
Comment 3 Scott Kovatch CLA 2010-08-05 14:44:15 EDT 
Fixed in HEAD. I moved out the addition of a magic number in a refactoring. I think fixing the button size problems addressed the "widget is disposed" error, but I need to get a newer I-build to verify for sure.
Comment 4 Scott Kovatch CLA 2010-08-05 15:08:00 EDT 
Marking as fixed, as I can't reproduce the remaining failures. There are other failures, but I don't necessarily have the same test environment.
Comment 5 Remy Suen CLA 2010-08-06 07:31:09 EDT 
Looks good to me on I201008051700. Thank you for addressing this matter so quickly, Scott.