Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 321831 - Egit packages visibility
Summary: Egit packages visibility
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: Core (show other bugs)
Version: 0.9.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-05 04:34 EDT by Mathias Kinzler CLA
Modified: 2012-02-17 08:27 EST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mathias Kinzler CLA 2010-08-05 04:34:11 EDT 
The packages in the different EGit projects are treated inconsistently: some packages with "internal" in their name are exposed to some friends; others are exposed even though they are not needed anywhere.
We should cleanup the package structure and the x-internal/x-friends/uses directives in all EGit projects.
Since we'll have to move some classes around packages, this will be a big refactoring, so it should probably be coordinated somehow in order to avoid too much merge pain for people with open changes.
Comment 1 Chris Aniszczyk CLA 2010-08-05 15:42:59 EDT 
This problem sucks.

Our packages are named poorly too.

We should be 'org.eclipse.egit.internal.core.*'

Also, I think everything in org.eclipse.egit.core and ui should be internal for now with proper x-friends relationships between core/ui.
Comment 2 Robin Rosenberg CLA 2010-08-19 17:19:31 EDT 
Does it help if I just agree?
Comment 3 Stefan Lay CLA 2010-09-07 05:57:57 EDT 
We take this up after 0.9.
Comment 4 Chris Aniszczyk CLA 2010-11-08 08:11:32 EST 
I'll look at this after 0.10, better we do this sooner than later :)
Comment 5 Mykola Nikishov CLA 2012-02-17 08:27:24 EST 
Chris, are you still going to take a look at this?