Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 321805 - Omit binary resources in History view
Summary: Omit binary resources in History view
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 0.9.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Stefan Lay CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-04 19:56 EDT by Benjamin Muskalla CLA
Modified: 2010-09-28 11:09 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Muskalla CLA 2010-08-04 19:56:14 EDT 
Currently the History view shows binary resources in commits as well in the description area. We could reuse the File Content mapping of Team to determinate if we can show the files or not. The files should still be comparable as the compare editor can figure it out itself.

As an example, see commit 7d64211cf2cb80492a9a6ee40752b7b77f78bb7a (Distinguish "Push" and "Commit" icons) in the History View.
Comment 1 Stefan Lay CLA 2010-09-28 11:09:27 EDT 
With commits a8b29afd82795b3d98b42bf (JGit) and 7445a9123e5a7f4b85 (EGit) there is now the ouput "Binary files differ" similar to the one in gitk or in the diff on command line.

I think that this bug can be closed. Please reopen if you are not satisfied with this solution.