Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 321790 - Refactoring: Move Module Entities [Contrib] [NoCQ]
Summary: Refactoring: Move Module Entities [Contrib] [NoCQ]
Status: CLOSED WONTFIX
Alias: None
Product: PTP
Classification: Tools
Component: Photran.Refactoring Engine (show other bugs)
Version: 6.0   Edit
Hardware: PC All
: P5 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Photran Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 319883 (view as bug list)
Depends on: 319883
Blocks:
  Show dependency tree
 
Reported: 2010-08-04 16:09 EDT by Matthew Fotzler CLA
Modified: 2014-08-12 11:39 EDT (History)
2 users (show)

See Also:

Attachments
refactoring (148.96 KB, text/plain)
2010-08-04 16:09 EDT, Matthew Fotzler CLA 		no flags Details
patch (149.26 KB, patch)
2010-08-10 11:05 EDT, Matthew Fotzler CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Fotzler CLA 2010-08-04 16:09:11 EDT 
Created attachment 175884 [details]
refactoring

This refactoring implements the spec outlined in section 4.7 of the tech report for moving named entities from one module to another.
Comment 1 Jeffrey Overbey CLA 2010-08-04 16:19:00 EDT 
Thanks.  Matt and Ashley, can you *both* please confirm that

1. you wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others,

2. you have the right to contribute the code to Eclipse, and

3. you have included the EPL license header in all source files?
Comment 2 Matthew Fotzler CLA 2010-08-04 16:20:22 EDT 
Yes, I wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others, I have the right to contribute the code to Eclipse, and I have included the EPL license header in all source files.
Comment 3 Ashley Kasza CLA 2010-08-04 16:47:52 EDT 
Yes, I wrote 100% of the code without incorporating content from elsewhere or
relying on the intellectual property of others, I have the right to contribute the code to Eclipse, and I have included the EPL license header in all source files.
Comment 4 Matthew Fotzler CLA 2010-08-10 11:05:22 EDT 
Created attachment 176243 [details]
patch

This patch is closer to the spec in terms of implementation.

NOTE: We have commented out calls to reindent the modified source code, due to a bug with the reindenter.
Comment 5 Jeffrey Overbey CLA 2010-08-10 13:58:40 EDT 
What is the reindenter bug again?  Do we have an entry for it in Bugzilla?  If not, could you please file one?  Then we should mark the bug dependency...

Thanks.
Comment 6 Jeffrey Overbey CLA 2010-09-21 11:57:33 EDT 
It looks like this patch includes the Add Use Statement refactoring, which is Bug 319883.  We need to keep these separate.  So when that bug is fixed, could you please resubmit this patch without that refactoring included in the patch?  Thanks!
Comment 7 Jeffrey Overbey CLA 2010-09-24 15:12:52 EDT 
*** Bug 319883 has been marked as a duplicate of this bug. ***
Comment 8 Jeffrey Overbey CLA 2010-09-24 15:13:51 EDT 
We decided to include Add Use Statement as part of this refactoring.  Need to try applying patch and send for IP review...
Comment 9 Jeffrey Overbey CLA 2011-03-14 14:09:43 EDT 
from Bug 321038: "There is also a bug when attempting to reindent with the Move Module Entities
refactoring that causes the majority of the file to be indented when it should
not be."
Comment 10 Jeffrey Overbey CLA 2011-03-17 23:34:34 EDT 
I didn't get this to the IP team for review in time for Indigo.  I'm going to mark it P5 and revisit it after June...
Comment 11 Jeffrey Overbey CLA 2014-08-12 11:39:09 EDT 
Unfortunately, there is no longer active development on this component.