Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 321638 - Launching the Rhino interpreter always shows echo in the console
Summary: Launching the Rhino interpreter always shows echo in the console
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: Debug (show other bugs)
Version: 3.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.3 M1   Edit
Assignee: Michael Rennie CLA
QA Contact: Simon Kaegi CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-03 13:55 EDT by Michael Rennie CLA
Modified: 2010-08-04 10:52 EDT (History)
1 user (show)

See Also:

Attachments
proposed fix (6.17 KB, patch)
2010-08-03 13:55 EDT, Michael Rennie CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2010-08-03 13:55:37 EDT 
Created attachment 175803 [details]
proposed fix

code from HEAD

When you launch the Rhino interpreter, either from code or using the new (proposed) single-click launch, you always get an echo in the console about the port, etc the interpreter was launched on. 

We should not show this all the time, it should only appear if requested.

The attached fix adds the 'trace' flag to enable/disable the echo. The new flag can be used for RhinoDebugger like: 

transport=socket,suspend=y,address=9000,trace=n

and for the DebugShell like:

-port 10002 -suspend false -trace false

In the case of the DebugShell tracing is enabled by default, so if you leave the flag off you get tracing, whereas with the RhinoDebugger you do not get tracing if you leave the flag off.
Comment 1 Michael Rennie CLA 2010-08-04 10:52:01 EDT 
applied to HEAD