Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 321574 - [call hierarchy] Remove Hierarchy scope for Call Hierarchy
Summary: [call hierarchy] Remove Hierarchy scope for Call Hierarchy
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: 3.7 M1   Edit
Assignee: Raksha Vasisht CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-03 06:43 EDT by Dani Megert CLA
Modified: 2010-08-05 02:49 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2010-08-03 06:43:04 EDT
I2010070802-1800.

Search In dialog: "Note:" should be bold like in the preference dialog.
Comment 1 Raksha Vasisht CLA 2010-08-04 06:46:17 EDT
(In reply to comment #0)
> I2010070802-1800.
> 
> Search In dialog: "Note:" should be bold like in the preference dialog.

Changing the title of the bug as we decided to remove the hierarchy scope altogether.
Comment 2 Raksha Vasisht CLA 2010-08-04 06:57:42 EDT
Fixed in HEAD.

Also changed the default values for the 'Search In' options -> set to all checked
Comment 3 Raksha Vasisht CLA 2010-08-04 07:06:48 EDT
(In reply to comment #2)
> Fixed in HEAD.
> 
> Also changed the default values for the 'Search In' options -> set to all
> checked

Fixed in :
1) /org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/callhierarchy/CallHierarchyMessages.java
2) /org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/callhierarchy/CallHierarchyMessages.properties
3) /org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/callhierarchy/SearchInDialog.java
4) /org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/callhierarchy/SearchScopeActionGroup.java
5) /org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/callhierarchy/SearchScopeHierarchyAction.java
Comment 4 Markus Keller CLA 2010-08-04 08:10:31 EDT
In HEAD, I've restored the value of SearchScopeActionGroup.SEARCH_SCOPE_TYPE_WORKING_SET. This value is stored in existing workspaces, so it must not be changed.

I've also verified that old workspaces that use the hierarchy scope correctly fall back to the workspace scope.
Comment 5 Raksha Vasisht CLA 2010-08-04 09:01:56 EDT
(In reply to comment #4)
> In HEAD, I've restored the value of
> SearchScopeActionGroup.SEARCH_SCOPE_TYPE_WORKING_SET. This value is stored in
> existing workspaces, so it must not be changed.
> 
> I've also verified that old workspaces that use the hierarchy scope correctly
> fall back to the workspace scope.

Thanks Markus, I overlooked that part.
Comment 6 Dani Megert CLA 2010-08-05 02:49:32 EDT
Verified in I20100804-1800 that the hierarchy scope is gone and the message removed from the dialog.