321519 – Single Root util not checking for classpath dependencies

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 321519 - Single Root util not checking for classpath dependencies

Summary: Single Root util not checking for classpath dependencies

Status:	RESOLVED WONTFIX

Alias:	None

Product:	WTP Java EE Tools
Classification:	WebTools
Component:	jst.j2ee (show other bugs)
Version:	3.0.5
Hardware:	PC Windows XP

Importance:	P3 normal (vote)
Target Milestone:	3.0.5 P
Assignee:	Jason Peterson
QA Contact:	Chuck Bridgham

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2010-08-02 11:35 EDT by Jason Peterson
Modified:	2010-08-11 12:00 EDT (History)
CC List:	1 user (show)

See Also:

Flags:	ccc: review+

Attachments
patch (5.26 KB, patch) 2010-08-02 11:35 EDT, Jason Peterson	ccc: iplog+	Details \| Diff
additional_patch (3.78 KB, patch) 2010-08-10 10:13 EDT, Jason Peterson	no flags	Details \| Diff
patch_to_revert (5.27 KB, patch) 2010-08-10 11:59 EDT, Jason Peterson	ccc: iplog+	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jason Peterson

2010-08-02 11:35:21 EDT

Created attachment 175721 [details]
patch

Projects containing classpath dependency attributes via the classpath tagging should not be considered single root.  A check for the classpath dependency attribute needs to be added to the single root utility.  This check already exists in the 3.2 stream.

Comment 1 Jason Peterson

2010-08-02 11:38:10 EDT

I have also backported the fix for bug 247090 as part of my patch.  This was necessary so that classpath dependencies with a deploy path other than "../" are not added to the parent component.

Comment 2 Carl Anderson

2010-08-04 12:23:36 EDT

Approved.

Comment 3 Carl Anderson

2010-08-05 13:33:07 EDT

Committed to R3_0_5_patches

Comment 4 Jason Peterson

2010-08-10 09:59:42 EDT

Reopening since part of this patch needs to be reverted

Comment 5 Jason Peterson

2010-08-10 10:13:03 EDT

Created attachment 176240 [details]
additional_patch

Comment 6 Jason Peterson

2010-08-10 11:59:07 EDT

Created attachment 176251 [details]
patch_to_revert

adding patch to revert the changes made by this bugzilla

Comment 7 Jason Peterson

2010-08-10 11:59:47 EDT

added a new patch to revert the original patch.

Comment 8 Carl Anderson

2010-08-11 12:00:27 EDT

Testing by the adopter has proven this to be a bad fix to make.  As such, we are undoing this from R3_0_5_patches.  The patch to remove the changes has been committed to R3_0_5_patches.