Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 321512 - [type wizards] Duplicated mnemonics keys in new Java Class wizard
Summary: [type wizards] Duplicated mnemonics keys in new Java Class wizard
Status: RESOLVED WONTFIX
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 3.7 M2   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-02 10:33 EDT by Roberto Sanchez Herrera CLA
Modified: 2010-09-10 06:33 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Roberto Sanchez Herrera CLA 2010-08-02 10:33:03 EDT
Build Identifier: I20100608-0911

The new Java Class wizard has duplicated mnemonic keys. For example, Alt + V is used for both the private modifier of the class, and for the main method checkbox. Alt + T is used for both the protected class modifier, and for the abstract modifier. 

Reproducible: Always

Steps to Reproduce:
1. Create a java project 
2. Open the new Java Class wizard
3. Press Alt to see the mnemonic keys
Comment 1 Dani Megert CLA 2010-08-03 03:01:26 EDT
It's hard to resolve those conflicts. Can you provide a non-conflicting solution? Note that 'F' is reserved for 'Finish' and we must only use 'a' to 'z' and 'A' to 'Z'.
Comment 2 Roberto Sanchez Herrera CLA 2010-08-03 10:00:33 EDT
(In reply to comment #1)
> It's hard to resolve those conflicts. Can you provide a non-conflicting
> solution? Note that 'F' is reserved for 'Finish' and we must only use 'a' to
> 'z' and 'A' to 'Z'.



That page is really crowded, but one option could be this:

1. Since there are 4 Browse buttons, and two of them use the same mnemonic -Alt + w- (I just noticed that), maybe the four buttons could use the same mnemonic (I know, this would still be a problem of repeated mnemonics, but that would leave 2 letters available: o and e)

2. Use Alt + O for the main method

3. Use Alt + E for the Protected modifier.
Comment 3 Dani Megert CLA 2010-08-03 10:10:04 EDT
>I know, this would still be a problem of repeated mnemonics, 
Right, this would just shuffle the problem around. So unless you have a non-conflicting solution I'll close this as WONTFIX (or rather CANTFIX ;-).
Comment 4 Markus Keller CLA 2010-08-03 12:22:46 EDT
The two 'Bro&wse' buttons are never enabled at the same time, so there's no conflict there.

'private' and 'protected' are only enabled if there is an enclosing type. We could remove their mnemonics so that you can toggle the conflicting checkboxes all the time (and access the remaining modifiers with Alt+U, Right (,Right)).
Comment 5 Roberto Sanchez Herrera CLA 2010-08-03 15:27:23 EDT
(In reply to comment #4)
> The two 'Bro&wse' buttons are never enabled at the same time, so there's no
> conflict there.
> 
> 'private' and 'protected' are only enabled if there is an enclosing type. We
> could remove their mnemonics so that you can toggle the conflicting checkboxes
> all the time (and access the remaining modifiers with Alt+U, Right (,Right)).

That sounds like a good option
Comment 6 Markus Keller CLA 2010-09-10 06:33:20 EDT
For "v", it's actually more common that you want to make the nested class private, so we won't change that. For "t", there's a tie between abstract and protected with no clear preference, so we leave that as well as it is.