Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 321437 - [performance] QuickFixCreateField is very slow
Summary: [performance] QuickFixCreateField is very slow
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-codan (show other bugs)
Version: 8.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 8.0   Edit
Assignee: Elena Laskavaia CLA
QA Contact: Elena Laskavaia CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-31 16:58 EDT by Marc-André Laperle CLA
Modified: 2010-08-18 11:23 EDT (History)
2 users (show)

See Also:

Attachments
Pass a non-null index to skip indexed headers (1.87 KB, patch)
2010-07-31 16:58 EDT, Marc-André Laperle CLA 		elaskavaia.cdt: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc-André Laperle CLA 2010-07-31 16:58:32 EDT 
Created attachment 175656 [details]
Pass a non-null index to skip indexed headers

QuickFixCreateField doesn't scale well when you have includes. It spends much of its time parsing code to build ASTs.

See:

IASTTranslationUnit ast = getTranslationUnitViaEditor(marker)
					.getAST(null, ITranslationUnit.AST_SKIP_INDEXED_HEADERS);

passing a null index as the effect of not skipping any headers.
Comment 1 Marc-André Laperle CLA 2010-08-18 00:03:28 EDT 
Hi Alena, can you take a look at this simple patch? This quick fix performs poorly in its current state. Thanks!
Comment 2 Elena Laskavaia CLA 2010-08-18 10:21:22 EDT 
patch applied on head, thanks