Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 321331 - [sync] NPE when committing from synchronize view
Summary: [sync] NPE when committing from synchronize view
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 0.9.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 0.10.0-M3   Edit
Assignee: Matthias Sohn CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-30 08:22 EDT by Ilya Klyuchnikov CLA
Modified: 2010-12-03 10:19 EST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Klyuchnikov CLA 2010-07-30 08:22:57 EDT 
This is for egit 0.9.0.201007281519

I select project > Team > Synchronize 
Then I select check "Include local uncommitted changes in comparison"

Synchronize view is populated, I select uncommitted changes in this view > "Commit .." and get NPE:


org.eclipse.swt.SWTException: Failed to execute runnable (java.lang.NullPointerException)
at org.eclipse.swt.SWT.error(SWT.java:4083)
at org.eclipse.swt.SWT.error(SWT.java:3998)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:137)
...
Caused by: java.lang.NullPointerException
at org.eclipse.egit.ui.internal.actions.RepositoryAction.run(RepositoryAction.java:69)
at org.eclipse.egit.ui.internal.synchronize.CommitOperation$2.run(CommitOperation.java:47)
at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:134)
... 47 more
Comment 1 François Rey CLA 2010-09-19 05:00:41 EDT 
I think I also have this with 0.9.3 except eclipse crashes on me and I have no way to check it was an npe (it's a jvm crash and I could not find any log anywhere). But the way to reproduce the crash is the same as described by original poster.
I'm on arch linux 64 bits, eclipse helios
Comment 2 Chris Aniszczyk CLA 2010-12-03 10:19:32 EST 
Fixed with http://egit.eclipse.org/r/#change,2018