Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 321306 - Convert line delimiters should report ignored binary files
Summary: Convert line delimiters should report ignored binary files
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.4.2   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 4.3 M3   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-30 05:12 EDT by Krzysztof Daniel CLA
Modified: 2012-10-05 10:14 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Daniel CLA 2010-07-30 05:12:04 EDT 
If you create a file in Package Explorer, and its type is binary (f.e. extension xyz), the convert line delimeters is active if the file is selected, however the action silently fails. 

It works for txt extension.

The action should either be inactive, or give error message.
Comment 1 Prakash Rangaraj CLA 2010-07-30 05:51:44 EDT 
How did you change the delimiter for a file? Delimiter information is available only on the Properties of the Project - not on the Properties of a file.
Comment 2 Eric Moffatt CLA 2010-08-17 14:32:17 EDT 
Just to clarify...is it just that the command is enabled when it should be disabled? If so I'll pass it on, if not please provide more info...
Comment 3 Francis Upton IV CLA 2010-11-02 03:33:05 EDT 
Guess this is related to the ConvertLineDelimitersAction which is part of text.
Comment 4 Markus Keller CLA 2012-10-05 10:14:54 EDT 
Fixed with http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=557ba618fc1d1f0161c453067e6b17fd848148b9

- shows a dialog if non-text files are selected
  - still converts without dialog if invoked from a text editor
- allows to see non-text files in the selection dialog